Repository navigation
Apply the $10 minimum payment in Michigan FIP, Virginia TANF, South Carolina TANF and Maryland TCA - #10261
Apply the $10 minimum payment in Michigan FIP, Virginia TANF, South Carolina TANF and Maryland TCA#10261PavelMakarchuk wants to merge 2 commits into
Conversation
Michigan: financial need requires an issuance deficit of at least $10 (BEM 518), for applicants as well as recipients. Virginia: the payment is the budgetary deficiency rounded down to whole dollars, and none is made under $10 (TANF Manual 502.1 A). South Carolina: no payment under $10 (S.C. Code Regs. 114-1140(A)(5)). Maryland: a benefit is issued only when it is at least $10 (COMAR 07.03.03.13 E(2)). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Review: Apply the $10 minimum payment in Michigan FIP, Virginia TANF, South Carolina TANF and Maryland TCASummaryThe PR adds a
It also adds 4 + 1 + 4 + 2 + 2 YAML cases, edits 3
Three things need fixing:
Critical (must fix)None. Should address1. The edited TANF-UP case conflicts with the approved #10253, both textually and on the law, and the body's overlap claim is out of date.
That held against #10253's earlier head (
Fix:
2. The new floor drops the cents of Virginia's fractional standards. Most payments land $1-$2 under the printed amounts, and the new 2025 test pins one. The floor at
The evidence:
Fix (either):
3. Add the The body (head Suggestions
Verified correct
Axiom line assessmentThe line is missing (Should 3), and
Recommended line. File a dispatch-ready
The issue should also include:
CI statusAll 27 checks pass at
The earlier non-green check was attempt 1's "Full Suite - Microsimulation". It was cancelled with "The job has exceeded the maximum execution time of 1h0m0s", which is infrastructure. Attempt 2, re-run 2026-10-23 21:05 UTC, passed that job in 40m24s. Nothing is pending or failing. Branch statusThe branch is 2 commits ahead of main (the change on 2026-10-16 and a merge of main on 2026-10-23) and 48 behind.
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
The law checks out in all four states: under $10 is strict, exactly $10 is paid, nothing rounds up, MI groups become ineligible and VA/SC/MD units stay eligible. No partner files are touched, and all 27 hand-checks pass. Three should-address items: (1) the edited VA TANF-UP case says the UP standard applies in 2021, which contradicts the approved #10253 ('every year'), and the two PRs now conflict, so align with #10253 and update the body's overlap claim; (2) flooring fractional VA standards leaves payments $1-2 under the printed 7/22 Appendix 2 (family of 3: $481 vs $482, and the new 2025 test pins $381 vs $382); (3) there's no axiom line. Four suggestions. Full report in the comment above.
Summary
Michigan, Virginia, South Carolina and Maryland pay nothing when the monthly amount is under $10; PolicyEngine paid any positive amount. This PR adds a
minimum_paymentparameter ($10) to each program, as Illinois, Nevada and Missouri have.mi_fip_income_eligiblenow requires an issuance deficit (payment standard lessmi_fip_countable_income_for_benefit) of at least $10 for every group, plus the qualifying test for groups that are not enrolled. Before, enrolled groups needed any positive deficit and applicants only the qualifying test.mi_fiponly gets a corrected comment.va_tanfnow rounds the capped payment down to whole dollars and returns 0 under $10.va_tanf_eligibilityis unchanged.sc_tanfreturns 0 under $10. (The TANF supplemental payment that 8.16 I lets count toward the $10 is not modeled.)md_tcareturns 0 under $10.Mississippi's $10 minimum is in #10209 and is not part of this PR.
Not changed here: South Carolina's rounding down to whole dollars (114-1140(A)(4)) and Maryland's rounding of net countable income down (COMAR 07.03.03.13 E(1)) are outside the issue.
Parameter start dates follow each program's existing parameters from the same source (MI 2008-10-01, SC 1996-07-01, MD 2016-01-01); Virginia's is 2020-07-01, the date of the 502.1 page.
Tests
va_tanf.yaml: four new monthly cases (deficiency of $2.44 and $9.99 pays $0, exactly $10 pays $10, $381.635 pays $381). The 2023 "small payment is still paid" case ($8.33 a month) now expects $0. One case's inputs change from $10,000 / $4,000 to $12,000 / $6,000 a year so the monthly amounts are exact and the rounding does not drop a float32 cent. Fiveintegration.yamlresults are rounded down (for example $191.60 to $191).mi_fip_income_eligible.yamlcases (enrolled $8 deficit fails, enrolled $10 passes, applicant passing the qualifying test with an $8 issuance deficit fails, applicant passing both passes) and one integration case (the issue's repro: $1,356 a month of earnings, family of 3, deficit $5,mi_fip= $0).sc_tanf.yaml: a benefit of $4.72 pays $0, $12.81 is paid (households of two people, so the cases also hold with Count South Carolina TANF unearned income at gross amounts and leave SSI recipients out of the benefit group #10184's benefit group size).md_tca.yaml: $4.80 pays $0, exactly $10 is paid.policyengine-core teston the four program folders: 267 passed; MD MEAP andgov/hhs/tanftests also pass.Overlap: the fix PRs for #9986 (#10247) and #9987 (#10253) also change Virginia TANF. This PR edits other lines of
va_tanf.py,va_tanf.yamlandintegration.yaml; its edit to the "If up tanf eligible" case inva_tanf.yamlis identical to #10253's. A trial merge of the three branches is clean, and the four program folders pass on the merged tree (279 tests). #10184 (open) changes other lines ofsc_tanf.py.Fixes #9985
🤖 Generated with Claude Code