Repository navigation
Fix stale comments and references in ten benefit income lists - #10410
PavelMakarchuk wants to merge 1 commit into
Conversation
Follow-up to #10317 (review suggestion N2). Comments and reference metadata only; no list entry changes. - MD CCS, AR SRA: annuities are modeled through pension_income, and military SBP annuities through military_retirement_income. - OH PFCC: add OAC 5180:6-1-03 (eff. 2026-08-01) and cite its (I) numbers, which moved down by one after the new (I)(5). - RI CCAP: Income is definition 29 in 218-RICR-20-00-4 4.2. - CO CCAP: the linked 2023 text numbers the list 3.105.1(I); add the current 3.111(I) text. - NM CCAP: add 8.9.3 NMAC (from 2022-11-01), which replaced 8.15.2. - PA, WV, ME, DC: page ranges in the titles; hrefs stay on the first page of the cited sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Review: Fix stale comments and references in ten benefit income listsSummaryHead Verified
Not re-verifiedI didn't open each cited PDF page to confirm its content, only the citation structure and numbering logic. The NM and OH paragraph mappings are internally consistent with the PR's own explanation. Suggestions
CI and branch27 pass and 3 skipping (wrapper jobs). The branch is 1 ahead and 53 behind main, and merge-tree is clean. Siblings #10408 and #10409 touch the PA list and the LIHEAP lists; trial merges were clean in their reviews. Verdict: APPROVE |
DTrim99
left a comment
There was a problem hiding this comment.
Metadata only: no list entry changes, the renumbered OH, NM and CO rules are dated rather than overwritten, the RI definition number is corrected, the multi-page references follow the CLAUDE.md format, and axiom n/a is valid. Approving. Full note in the comment above.
Summary
Follow-up to #10317 (DTrim99's round-2 suggestion N2). The ten benefit income lists below had comments and references that were stale after #10317 or out of date with the current rule text. This PR changes comments and reference metadata only. No list entry, value or formula changes, so no output changes.
TheAxiomFoundation/rulespec-us#1870 records the per-program sources. I re-read each source on 2026-10-23 before each change.
Stale comments
md/msde/ccs/income/countable_income/sources.yamlpension_income; military retired pay and SBP annuities throughmilitary_retirement_income. Still not modeled: commissions, tips, bonuses, estate income, and the military bonuses and allowances in (b)(vii).ar/ade/oec/sra/income/sources.yamlpension_income, and SBP annuities throughmilitary_retirement_income.pension_incomeis documented as "Income from pensions, annuitities, life insurance or endowment contracts", so a non-military annuity was already counted in both lists.Stale references
#page=59.#page=51.#page=13.#page=12.Why page ranges, not new anchors
#1870 and the N2 note give one page for PA (60), WV (55), ME (14) and DC (13): the page of the pension or military retirement item. Each of these lists also cites earned income and other items on the earlier pages, so moving the anchor would drop those. CLAUDE.md says a multi-page citation keeps the href on the first page and ends the title with the range, so I did that.
Not changed (follow-ups)
earned_sources.yaml,net_loss_sources.yaml,minor_age_limit.yaml, two variables, three test files) still cite 5180:2-16-03 only.Tests
make format: no change to the touched files. (Locally, ruff 0.14.14 also reformats two unrelated Python files on main; I left them out.)test_source_conflicts.py,test_reference_urls.py,test_military_retirement_readers.py,test_known_dead_reference_urls.py,test_no_concatenated_reference_urls.py,test_parameter_yaml_keys.py: 261 passed.test_batched.py --mode per-subdir --workers 1): 1,258 passed, 0 failed (MD CCS 110, AR SRA 197, OH PFCC 140, RI CCAP 139, CO CCAP 65, NM CCAP 118, PA CCW 113, WV CCAP 107, ME CCAP 181, DC CCSP 88).axiom: n/a: comment and reference metadata only; no policy change (TheAxiomFoundation/rulespec-us#1870 already records these sources)
🤖 Generated with Claude Code