Skip to content

Fix stale comments and references in ten benefit income lists - #10410

Open
PavelMakarchuk wants to merge 1 commit into
mainfrom
fix-benefit-income-list-references
Open

PavelMakarchuk wants to merge 1 commit into
mainfrom
fix-benefit-income-list-references

Conversation

@PavelMakarchuk

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #10317 (DTrim99's round-2 suggestion N2). The ten benefit income lists below had comments and references that were stale after #10317 or out of date with the current rule text. This PR changes comments and reference metadata only. No list entry, value or formula changes, so no output changes.

TheAxiomFoundation/rulespec-us#1870 records the per-program sources. I re-read each source on 2026-10-23 before each change.

Stale comments

List Before After Source
MD CCS md/msde/ccs/income/countable_income/sources.yaml "annuities" and "military entitlements" among the COMAR sources "we don't model" (b)(v) pensions and annuities are modeled through pension_income; military retired pay and SBP annuities through military_retirement_income. Still not modeled: commissions, tips, bonuses, estate income, and the military bonuses and allowances in (b)(vii). COMAR 13A.14.06.02B(28)(b): "(v) Pensions and annuities; … (vii) Military entitlements, bonuses, and allowances"
AR SRA ar/ade/oec/sra/income/sources.yaml "annuities" among the sources with "no matching variables" Annuities removed from that list; a note says they are modeled through pension_income, and SBP annuities through military_retirement_income. FSU Procedural Manual (June 2023) 4.3.2, file page 20: "Pensions, interest, and annuities"

pension_income is documented as "Income from pensions, annuitities, life insurance or endowment contracts", so a non-military annuity was already counted in both lists.

Stale references

List Change Source checked
OH PFCC Added OAC 5180:6-1-03 (eff. 2026-08-01) next to the 2022 rule OAC 5180:2-16-03, because the list's single value covers both editions. Comments now cite the 2026 numbers: SNAP (I)(22)→(I)(23), refunds (13)→(14), EITC (15)→(16), energy (12)→(13), lump sums (23)→(24). A comment records the renumbering. Both PDFs read. (F) and (H) are the same in both. The 2026 rule adds (I)(5) "Federal and state kinship care payments", so 2022 items (I)(5)-(25) are (I)(6)-(26).
RI CCAP "Definition 30" → "Definition 29" in the reference title and the comment. The linked page (active filing, eff. 2026-06-11) has "29. “Income” means…" and "30. “Income eligible” means…".
CO CCAP "Section 7.105" → "Section 3.105.1(I) … #page 22-26" for the linked ruleVersionId 11042 (eff. 2023-08-14). Added ruleVersionId 12658 (eff. 2026-08-14), "Section 3.111(I) … #page 46-51". Neither version has a 7.105. In 11042, "I. Income Inclusions" starts on file page 22 and item 33 ends on page 26. In 12658, 3.111 is "LOW-INCOME CHILD CARE ELIGIBILITY", and (I) runs from page 46 to page 51.
NM CCAP Added 8.9.3 NMAC "(from 2022-11-01)" next to 8.15.2 NMAC "(before 2022-11-01)". Comments cite 8.9.3.11, with a note that 8.15.2.11 applies before 2022-11-01; "CYFD" → "the department (CYFD, now ECECD)". 8.9.3.5: "EFFECTIVE DATE: November 1, 2022". The ECECD notice (NM Register XXXIII-16) labels 8.9.3 "Formerly 8.15.2 NMAC". 8.9.3.11.C keeps the paragraph numbers; (3) and (5) have the same income text (agency name aside), and (6) adds only "Tribal per capita payments" (also in the Nov. 2025 integrated text).
PA CCW Title gets "#page 59-60"; href stays #page=59. Appendix A Part I starts on file page 59 (items A-I) and ends on page 60 (items J-U). Item J, "Government employee pensions … including members of the armed forces, or their survivors", is on page 60.
WV CCAP Title gets "#page 51-55"; href stays #page=51. 5.2 and 5.2.1 start on file page 51; 5.2.4.4 "Pensions and annuities" is on page 55.
ME CCAP Title gets "#page 13-16"; href stays #page=13. §2.C.3 Earned Income starts at the bottom of file page 13; §2.C.4 Unearned Income runs from page 14 (item a, military retirement and annuities) to page 16 (item z).
DC CCSP Title gets "Sections 2.5.2-2.5.3 #page 12-14"; href stays #page=12. 2.5.2 Countable Income starts on file page 12 (wages); pensions, annuities and military retirement are on page 13; 2.5.3 Exempt Income, which the list's comment uses, ends on page 14.

Why page ranges, not new anchors

#1870 and the N2 note give one page for PA (60), WV (55), ME (14) and DC (13): the page of the pension or military retirement item. Each of these lists also cites earned income and other items on the earlier pages, so moving the anchor would drop those. CLAUDE.md says a multi-page citation keeps the href on the first page and ends the title with the range, so I did that.

Not changed (follow-ups)

  • Other OH PFCC files (8: earned_sources.yaml, net_loss_sources.yaml, minor_age_limit.yaml, two variables, three test files) still cite 5180:2-16-03 only.
  • Other NM CCAP files (23 parameters, variables and tests) still cite 8.15.2 NMAC only; some of them are copay and FPL parameters whose 8.9.3 values need a separate check.

Tests

  • make format: no change to the touched files. (Locally, ruff 0.14.14 also reformats two unrelated Python files on main; I left them out.)
  • Code-health: test_source_conflicts.py, test_reference_urls.py, test_military_retirement_readers.py, test_known_dead_reference_urls.py, test_no_concatenated_reference_urls.py, test_parameter_yaml_keys.py: 261 passed.
  • YAML tests of the ten programs (test_batched.py --mode per-subdir --workers 1): 1,258 passed, 0 failed (MD CCS 110, AR SRA 197, OH PFCC 140, RI CCAP 139, CO CCAP 65, NM CCAP 118, PA CCW 113, WV CCAP 107, ME CCAP 181, DC CCSP 88).

axiom: n/a: comment and reference metadata only; no policy change (TheAxiomFoundation/rulespec-us#1870 already records these sources)

🤖 Generated with Claude Code

Follow-up to #10317 (review suggestion N2). Comments and reference
metadata only; no list entry changes.

- MD CCS, AR SRA: annuities are modeled through pension_income, and
  military SBP annuities through military_retirement_income.
- OH PFCC: add OAC 5180:6-1-03 (eff. 2026-08-01) and cite its (I)
  numbers, which moved down by one after the new (I)(5).
- RI CCAP: Income is definition 29 in 218-RICR-20-00-4 4.2.
- CO CCAP: the linked 2023 text numbers the list 3.105.1(I); add the
  current 3.111(I) text.
- NM CCAP: add 8.9.3 NMAC (from 2022-11-01), which replaced 8.15.2.
- PA, WV, ME, DC: page ranges in the titles; hrefs stay on the first
  page of the cited sections.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DTrim99

DTrim99 commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

PR Review: Fix stale comments and references in ten benefit income lists

Summary

Head ac42f847d9. The PR edits only comments and references in ten state benefit income source lists (AR SRA; CCAP or child care lists for CO, DC, MD, ME, NM, OH, PA, RI and WV), plus a changelog fragment. No list entry is added or removed, so no output changes. Nothing critical or should-address is open.

Verified

  • No value change. No - variable line is added or removed in any sources.yaml.
  • Renumbered rules are dated, not overwritten. OH keeps OAC 5180:2-16-03 (effective 2022-02-27) and adds 5180:6-1-03 (effective 2026-08-01); the (I) items shift by one because the 2026 rule inserts (I)(5), and the comments now cite the 2026 numbers. NM adds 8.9.3 NMAC (ECECD, from 2022-11-01) next to 8.15.2 NMAC (before), with the paragraph mapping explained. CO adds 3.111(I) (effective 2026-08-14) next to 3.105.1(I) (2023-08-14). RI corrects Definition 30 to Definition 29.
  • Reference format (CLAUDE.md): every multi-page title ends with a quoted #page a-b, and its href opens the first page (CO #page=22 and #page=46, DC #page=12, ME #page=13, PA #page=59, WV #page=51).
  • AR and MD comments now say where annuities are modeled (pension_income) and that military retired pay and SBP annuities come through military_retirement_income, consistent with Count military SBP annuities in state benefit income lists #10317.
  • Source-conflict ratchet: no added line reads like a source conflict (static check: 0 matches).
  • Axiom: n/a: comment and reference metadata only; no policy change is valid for a metadata-only PR.

Not re-verified

I didn't open each cited PDF page to confirm its content, only the citation structure and numbering logic. The NM and OH paragraph mappings are internally consistent with the PR's own explanation.

Suggestions

  1. When the 2026 OH and CO rules become the only ones in force for modeled years, consider dropping the superseded entries' dates from the comments to keep them short. Optional.

CI and branch

27 pass and 3 skipping (wrapper jobs). The branch is 1 ahead and 53 behind main, and merge-tree is clean. Siblings #10408 and #10409 touch the PA list and the LIHEAP lists; trial merges were clean in their reviews.

Verdict: APPROVE

@DTrim99 DTrim99 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata only: no list entry changes, the renumbered OH, NM and CO rules are dated rather than overwritten, the RI definition number is corrected, the multi-page references follow the CLAUDE.md format, and axiom n/a is valid. Approving. Full note in the comment above.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants