Repository navigation
Vendor the source-conflict register at rulespec-us ad03b325 - #10445
Merged
Merged
Conversation
Pin the register to TheAxiomFoundation/rulespec-us@ad03b32, the merge commit of rulespec-us#1908, which also includes #1907. - #1908 repins the nine PolicyEngine-US implementations marked in #10441 to eeaf809 and sets cites_entry: true on each. The guard's test_registered_implementations_carry_their_marker now requires those nine markers. Removing the niit_magi.py marker makes it fail. - #1907 adds two Social Security entries, oasdi-dual-entitlement-zero-after-age-reduction and oasdi-parent-entitlement-count-interval, and gives oasdi-family-maximum-saving-clause an implementation, four tests and a money case. All three are implemented only in microcosm-dynamics, so no PolicyEngine-US marker or candidate changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
October 25, 2026 08:17
Contributor
Author
|
Hand-off to the US hub, at head 62b0b48.
|
Contributor
Author
|
US + core hub merge audit, us#10445 at
|
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
axiom: n/a (vendors the shared register; no rule or model change)
What this changes
This PR vendors
source_conflicts/known-source-conflicts.yamlat TheAxiomFoundation/rulespec-us@ad03b325. That commit merges TheAxiomFoundation/rulespec-us#1908, and it also includes TheAxiomFoundation/rulespec-us#1907.scripts/update_source_conflicts.py --commit ad03b32553749edc6e332b815487a9311ef9ed58wrote bothknown-source-conflicts.yamlandpin.yaml.eeaf8096, the Mark nine source conflicts now in the shared register #10441 merge commit, and setscites_entry: trueon each. With this pin,test_registered_implementations_carry_their_markerrequires those nine markers. I checked this by removing theniit_magi.pymarker locally: that test failed (1 failed, 102 passed). Restoring the marker made it pass again.oasdi-dual-entitlement-zero-after-age-reductionandoasdi-parent-entitlement-count-interval. It also replaces theproposedrecord onoasdi-family-maximum-saving-clausewith the shipped implementation, and adds four tests and a money case to that entry. All three entries are implemented only in PolicyEngine/microcosm-dynamics. None names a PolicyEngine-US file, andcandidates.yamllists none of them, so no marker or candidate changes here.The register now has 22 entries (20 before). No entry was removed. No PolicyEngine-US code, parameter or test changes.
Invariants
The guard in
policyengine_us/tests/code_health/test_source_conflicts.pychecks each of these:pin.yaml.cites_entry: truePolicyEngine-US implementation carries its marker. This PR makes this invariant bind on nine files.KNOWN_UNMARKED. This PR leaves that baseline unchanged.candidates.yamlis also a register id.Verification
candidates.yamland their own changelog fragments, and this PR touches neither. Point the federal and AK-HI source-conflict candidates at their code on main #10350 and Add source-conflict candidates for SSP, Maryland CCS and NY HEAP #10444 have since merged. Point the IN-MT source-conflict candidates at their code on main #10351 and Point the NM-WY source-conflict candidates at their code on main #10352 are still open, and their merge order relative to this PR doesn't matter.Changelog
changelog.d/source-conflict-register-cites.changed.md🤖 Generated with Claude Code