Repository navigation
Base the Illinois EIC on the federal EITC alone before 2023 and add the 2000–2017 match rates - #9824
Conversation
35 ILCS 5/212(b-5), (b-10) and (b-15) extend the credit to childless filers aged 18-24 and 65+ and to ITIN filers only for taxable years beginning on or after January 1, 2023. Fixes #9823. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9824 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 1 -3
Lines 76 25 -51
Branches 2 1 -1
=========================================
- Hits 76 25 -51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hua7450
left a comment
There was a problem hiding this comment.
Reviewed 9a4b7b7. No calculation defect found in the static review. Delegating the pre-2023 calculation to federal eitc preserves the federal eligibility rules, including the temporary 2021 ARPA age rules. The 2023 expanded Illinois calculation remains unchanged.
- Please add the required
axiom:parity declaration to the PR description, following CLAUDE.md's Axiom Parity section. - Optional regression coverage: add otherwise-identical ITIN cases for 2022 and 2023 to pin the expansion boundary alongside the age tests.
Verification limits: I did not independently run the tests. All 37 check runs on this commit are successful as of October 6, 02:40 UTC. The source audit is partial because some historical Illinois primary documents could not be retrieved.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks. Merged
The Illinois tests pass (906). I will add the |
PR Review: Use 18% of the federal EITC for the Illinois EIC before 2023SummaryThe PR adds
Critical (must fix)None. Should address1. Add the IL match rates for 2017 and earlier, or narrow the claim to 2018–2022. File: What's wrong. The values are The law. 35 ILCS 5/212(a): "(i) 5% of the federal tax credit for each taxable year beginning on or after January 1, 2000 and ending prior to December 31, 2012, (ii) 7.5% … beginning on or after January 1, 2012 and ending prior to December 31, 2013, (iii) 10% … beginning on or after January 1, 2013 and beginning prior to January 1, 2017, (iv) 14% … beginning on or after January 1, 2017 and beginning prior to January 1, 2018, (v) 18% … beginning on or after January 1, 2018 and beginning prior to January 1, 2023, and (vi) 20% … on or after January 1, 2023." rulespec-us Fix (preferred). Add Fallback. Reword the title and changelog to "2018–2022" and file an issue for the earlier rates. 2. Fix the ITIN citation in the new test. File: 3. Add the The body has no line mentioning What rulespec-us has. Recommended line. File a dispatch-ready
Alternatively, extend rulespec-us#1699 (IL1, OPEN, Suggestions
Verified correct
Axiom line assessmentThere is no CI statusAll 26 reported checks pass at Branch statusThe branch is 3 commits ahead of main and 319 behind. Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
The gate and the 2021-2022 results are correct (35 ILCS 5/212; Schedule IL-E/EIC 2022 lines 5-6). Three should-address items: (1) match.yaml extrapolates 18% back before 2018, but the law gives 14% (2017), 10% (2013-16), 7.5% (2012) and 5% (2000-11), so add the dated rates and a 2017 case or narrow the claim to 2018-2022; (2) the ITIN comment cites (b-5) instead of (b-15); (3) there's no axiom line. Two suggestions. Full report in the comment above.
- match.yaml now has the full 35 ILCS 5/212(a) schedule: 5% (2000), 7.5% (2012), 10% (2013), 14% (2017), 18% (2018) and 20% (2023), with the statute reference. Before, 18% was extrapolated back from 2021. - expansion_in_effect starts at 2000-01-01: false, and its description uses the "if this is true" form; the note on the earlier credit moves to the il_eitc code comment. - New cases: a 2017 childless filer gets 14% of the federal EITC (53.55), and a 2021 childless filer aged 65 gets 18% through the federal credit under IRC 32(n) (137.70). - The 2023 ITIN case cites 35 ILCS 5/212(b-15), not (b-5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, David. Commit 6280f44 addresses the review. Should 1: rates before 2018.
The values are Should 2: ITIN citation. The test comment now cites (b-15). The statute's (b-15) is the ITIN route: "each individual taxpayer filing a return using an individual taxpayer identification number (ITIN) ... is entitled to the credit". Should 3: Suggestion 1. Added "Childless filer aged 65 in 2021 gets 18% of the federal EITC": IRC 32(n)(2) drops "but not attained age 65" and 32(n)(3) sets 15.3%, so 15.3% × 5,000 = 765, × 18% = 137.70. Suggestion 2. The All 18 cases in |
PR Review (round 2): Base the Illinois EIC on the federal EITC alone before 2023 and add the 2000–2017 match ratesSummaryOne author commit since round 1 (
Open: 0 critical, 1 should, 0 suggestions. Prior findings
New findingsNone. VerifiedRate schedule.
Hand-checked expectations (every new or changed one). All three are single filers with $5,000 of wages and no children.
Reach of the rate change. No IL tax test on main or at the head has a period of 2017 or earlier, apart from the new case. The IL partner Years before 2017.
Code and parameters.
Changelog. Source-conflict ratchet (#10287). The head tree predates the guard. I ran main's Partner tests. No files under Axiom line assessmentStill missing, so Should 3 stays open. Pavel is staff, so What's needed. File the drafted issue on rulespec-us. It must be OPEN, labelled
About the companion cases. The author plans to reuse this PR's cases. That works only if the issue presents each one with its external derivation, not as PolicyEngine output. For example: the Rev. Proc. 2016-55 amounts × 14% = 53.55; IRC 32(n) × 18% = 137.70; and the 2022 Schedule IL-E/EIC lines 5–6. Alternative. Extend rulespec-us#1699 (OPEN, CI status
The failure is "Package and compatibility" (run 40317907190, job 121555249060). It is caused by main and is not a finding.
Branch statusThe branch is 4 commits ahead of main and 355 behind.
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
Round 2: S1 is fixed (match.yaml now has the full 35 ILCS 5/212(a) schedule from 2000, plus a 2017 case), and so are S2 and both suggestions. All new expectations hand-check. One item still open: there's no axiom line and no rulespec-us issue yet. Please file the drafted pe-parity issue and add 'axiom: rulespec-us# queued', or extend #1699. The red 'Package and compatibility' check is main-caused (the branch's uv.lock revision 3 vs main's uv 0.13.4 after #10377), so merge main and re-run. Full report in the comment above.
|
Thanks, David.
|
PR Review (round 3): Base the Illinois EIC on the federal EITC alone before 2023 and add the 2000–2017 match ratesSummaryHead Prior findings
Axiom
CI and branchThe merge with Verdict: APPROVE |
DTrim99
left a comment
There was a problem hiding this comment.
Round 3: the last open item is fixed. rulespec-us#1919 queued is open, pe-parity labelled, and dispatch-ready, with companion cases matching this PR's YAML, and the main merge changed none of the PR's files. A few Contrib shards were still pending when I checked, so please let CI finish green before merging. Full note in the comment above.
Fixes #9823.
Change
gov.states.il.tax.income.credits.eitc.expansion_in_effect: false before 2023, true from 2023 (35 ILCS 5/212(b-5), (b-10), (b-15)).il_eitcreturnseitc × match. This is Schedule IL-E/EIC Step 4: line 5 is the federal EIC, line 6 is 18% of it (2018–2022).match.yamlnow has the full 35 ILCS 5/212(a) schedule: 5% (2000–2011), 7.5% (2012), 10% (2013–2016), 14% (2017), 18% (2018–2022) and 20% (2023 on). Before, 18% was extrapolated back from 2021.Tests
New file
il_eitc_pre_2023.yaml, single filer with $5,000 of wages and no children:The expected values are the § 212(a) rate times the federal EITC:
TAXSIM-35 itself also gives the 2021–2022 Illinois credit to the filers with no federal EITC, so its
v39is not used as the expected value.The existing "2021 Illinois Zero EITC" test now sets
eitc_earned_incomeinstead offiler_adjusted_earnings, because the 2021 credit now comes from the federaleitc. #9820 makes the same change to this line, so the two PRs merge cleanly.All Illinois tax tests pass locally.
Census effect
In the TAXSIM-35 census comparison for Illinois, 6 household-years change (2021–2022 households where a spouse has a self-employment loss) and none that matched before stop matching. 3 now match TAXSIM; the 3 from 2021 also need #9822 (rebate at negative AGI).
axiom: TheAxiomFoundation/rulespec-us#1919 queued (open,
pe-parity; the signed encoder dispatch needs approval)🤖 Generated with Claude Code