Repository navigation
Let the Test jobs run for 105 minutes - #737
Merged
Merged
Conversation
On Python 3.11 to 3.13, coverage.py 7.13.5 records coverage with its C trace function (it uses sys.monitoring only on 3.14), so the Test jobs there take 65 to 90 minutes, and one of them was often cancelled at the 90-minute limit with no failing test: 3.12 on #730, 3.11 on #735. The 3.14 job takes 47 to 60 minutes. The push-to-main Test job runs the same suite and keeps the same limit as the pull-request one, so a release run isn't cancelled before Versioning either. Fixes #736 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
marked this pull request as ready for review
November 3, 2026 19:26
anth-volk
added a commit
that referenced
this pull request
Nov 3, 2026
Brings in #737, which lets the Test jobs run for 105 minutes instead of 90; the 3.11 and 3.13 Test jobs on this branch stopped at the old limit. No conflicts: #701, also new on main, changes model metadata and none of the UK area lists or area results this branch edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #736
Summary
Raises
timeout-minutesfrom 90 to 105 on the two jobs that run the full test suite with coverage (make test, which ispytest tests --cov=policyengine --cov-report=term-missing):.github/workflows/pr_code_changes.yaml, jobTest(the "Test (3.11)" to "Test (3.14)" matrix).github/workflows/push.yaml, jobTest(pushes tomain; its comment says it matches the pull-request Test job, so a release run isn't cancelled before Versioning)Also adds
changelog.d/736.changed.mdand updates the comments above both limits.Why
On Python 3.11 to 3.13, coverage.py 7.13.5 (from
uv.lock) records coverage with its C trace function; it switches tosys.monitoringonly on 3.14. Those jobs now take 65 to 90 minutes, and one of them is often cancelled at 90 minutes with no failing test:Left unchanged
pr_docs_changes.yaml(docs build, 30 min),draft-pdf.yml(paper, 15 min) andcertify-uk-release.yaml(its jobs run their own checks with their own limits; it startspr_code_changes.yamlwithgh workflow run, so that run picks up the new limit).Environment variables
This PR changes no environment variable, secret or variable reference. The two changed jobs read:
HUGGING_FACE_TOKEN: repository secret (an organisation secret of the same name also exists), passed assecrets.HUGGING_FACE_TOKENin theenv:of the "Run tests with coverage" step, the only step that uses it, in both jobs.CI_RUNNER_X64andCI_RUNNER_EVENTS: repository variables read in each job'sruns-onexpression. Neither is set at repository or organisation level, so both jobs run onubuntu-latest.Overlap
#731 sets both limits to 150 on its own branch. Whichever merges second will need its
timeout-minutesvalues and comments reconciled.Possible follow-up (not in this PR)
Measure coverage only on 3.14 and run plain
pyteston 3.11 to 3.13. That would bring those jobs down to about the 3.14 time.Checks run
actionlinton both workflows: no new findings (one existing warning aboutactions/configure-pages@v3inpush.yaml, also onmain).Testjobs havetimeout-minutes: 105.make lint: passes.🤖 Generated with Claude Code