feat(command-menu): show keyboard shortcuts in command menu#3005
Merged
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "feat(command-menu): show keyboard shortc..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
MattPua
changed the title
Contributor
|
Reviews (2): Last reviewed commit: "fix(command-menu): right-align shortcuts..." | Re-trigger Greptile |
charlesvien
requested changes
Jun 30, 2026
charlesvien
left a comment
charlesvien
left a comment
Member
There was a problem hiding this comment.
This is quite nice, can you add a tad bit spacing between each key tho similarly to how we have it in the "CMD+," shortcut menu?
Generated-By: PostHog Code Task-Id: 98391aef-093c-485d-a01e-ce8dc7f407e9
Generated-By: PostHog Code Task-Id: 98391aef-093c-485d-a01e-ce8dc7f407e9
Generated-By: PostHog Code Task-Id: 98391aef-093c-485d-a01e-ce8dc7f407e9
Generated-By: PostHog Code Task-Id: fcb4960f-501b-4784-aab9-c264bebe1755
Re-applies Greptile's P2 suggestion (positional, static list) on top of the clipping fix, which had reverted it to the formatted-string key. Generated-By: PostHog Code Task-Id: 98391aef-093c-485d-a01e-ce8dc7f407e9
Biome's required `noArrayIndexKey` check rejects `key={i}`, which conflicts
with the earlier Greptile suggestion. The formatted part is a safe key here:
a shortcut never yields duplicate formatted parts (no repeated modifiers).
Generated-By: PostHog Code
Task-Id: 98391aef-093c-485d-a01e-ce8dc7f407e9
Match the keyboard shortcuts sheet, which renders key parts with a gap-1 (4px) between them, by giving the command menu's KbdGroup an explicit gap-1 so the keys aren't cramped together. Generated-By: PostHog Code Task-Id: 85b2e7d0-e251-47ac-81bf-217751cd480a
MattPua
force-pushed
the
posthog-code/command-menu-shortcuts
branch
from
e90cd4f to
de50fcd
Compare
The quill KbdGroup wrapper wasn't honoring the gap-1 utility, so the shortcut keys still rendered flush against each other. Drop KbdGroup and render the Kbd keycaps directly in a flex container with gap-1, matching the spacing in the keyboard shortcuts sheet. Generated-By: PostHog Code Task-Id: 85b2e7d0-e251-47ac-81bf-217751cd480a
Surface history navigation in the command menu's Navigation section with "Go back" and "Go forward" entries, wired to the existing goBackInHistory / goForwardInHistory router bridge and showing their GO_BACK (mod+[) and GO_FORWARD (mod+]) shortcuts right-aligned. Adds the two new action types to CommandMenuAction for analytics. Generated-By: PostHog Code Task-Id: 85b2e7d0-e251-47ac-81bf-217751cd480a
Bump the flex gap between Kbd keycaps from gap-1 to gap-2 so the spacing between keys (e.g. ⌘ and [) is clearly visible. Generated-By: PostHog Code Task-Id: 85b2e7d0-e251-47ac-81bf-217751cd480a
Member
Author
Biome's formatter wants the @phosphor-icons/react import on one line since it fits within the print width. Fixes the failing quality check. Generated-By: PostHog Code Task-Id: 85b2e7d0-e251-47ac-81bf-217751cd480a
Reorder the Navigation section to Home → Settings → Go back → Go forward so the history actions sit beneath Settings. Generated-By: PostHog Code Task-Id: 85b2e7d0-e251-47ac-81bf-217751cd480a
Swap the section order so Actions appears first, followed by Navigation. Generated-By: PostHog Code Task-Id: 85b2e7d0-e251-47ac-81bf-217751cd480a
MattPua
changed the title
MattPua
force-pushed
the
posthog-code/command-menu-shortcuts
branch
from
f5691b8 to
844aef4
Compare
MattPua
force-pushed
the
posthog-code/command-menu-shortcuts
branch
from
844aef4 to
cf81f7e
Compare
MattPua
changed the title
charlesvien
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Created with PostHog Code