feat(bluebird): mirror Code view's top nav in the Website space#3028
feat(bluebird): mirror Code view's top nav in the Website space#3028raquelmsmith wants to merge 3 commits into
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "feat(bluebird): mirror Code view's top n..." | Re-trigger Greptile |
|
|
Reviews (3): Last reviewed commit: "fix(bluebird): address review findings o..." | Re-trigger Greptile |
Bring the Website (Bluebird / Channels) left nav to parity with the Code view, keeping every destination inside the /website space instead of bouncing back to /code. New order: Home · Search · Inbox · Canvas · Agents · Customize. - Search: adds the shared SearchItem (opens the command menu, ⌘K hint). - Inbox: forks the whole inbox subtree under /website/inbox/* sharing the same view components. Navigation is space-aware via inboxSpaceFromPath + per-space route maps in @posthog/core and a useInboxSpace/useInboxRoutes hook, so every tab, card, back-link and redirect stays in the active space. Uses the real InboxItem (PR-review badge + Beta tag). Cmd+I and the "open associated report" action are space-aware too. - Agents: forks the agents subtree under /website/agents/* (scouts + agent-applications platform). A space-keyed AGENTS_ROUTE map + a useAgentsRoutes hook drive every link/navigate across the shared components (incl. the agent-builder client tools). - Customize: a new /website/customize page with its own secondary left sidebar (Skills · MCP servers), replacing the old standalone /website/skills and /website/mcp-servers routes. useAppView active-state mapping and the route tree are updated for both spaces. Generated-By: PostHog Code Task-Id: dd8d849b-2434-42fd-a147-701e8fd06232
The doc + inline comments still claimed Inbox and Agents have no /website mirror and jump back to Code, contradicting the now space-aware goInbox / goAgents handlers. Update them so a future reader doesn't "fix" the mirroring away. Generated-By: PostHog Code Task-Id: dd8d849b-2434-42fd-a147-701e8fd06232
Greptile review findings: - P1: in the Channels space, the Code-pane SidebarNavSection routed both Skills and MCP servers to /website/customize, which redirects to Skills — so MCP servers silently opened Skills. Add distinct navigateToWebsiteCustomizeSkills / navigateToWebsiteCustomizeMcpServers targets and point each item at its own sub-route. - P2: hoist the constant RegExp in inboxTabFromPath to module scope so it's compiled once instead of per call. - P2: CustomizeLayout derived isSkills as `!isMcp`; make it an explicit prefix check so a future third sub-route doesn't light up the Skills item. Generated-By: PostHog Code Task-Id: dd8d849b-2434-42fd-a147-701e8fd06232
35fd04a to
e1a0b5f
Compare
|
🤖 Agent (PostHog Code) posting on @raquelmsmith's behalf at her request. Rebased onto All Greptile review findings are addressed on the branch:
Verified after rebase: |
Problem
The Code view of PostHog Code has a set of top items in the left nav that were missing from the Website (Bluebird / Channels) view, and the ones that did exist bounced the user back to the
/codespace. This brings the Website nav to parity and keeps every destination inside/website.Why: the Website space should stand on its own — navigating to Inbox, Agents, etc. shouldn't kick you out of Channels and into the Code view.
Changes
The Website left nav now mirrors the Code view's top items, all staying in the
/websitespace. New order: Home · Search · Inbox · Canvas · Agents · Customize.SearchItem(opens the command menu, shows the⌘Khint), identical to the Code view./website/inbox) — the inbox subtree is forked under/website/inbox/*sharing the same view components. Navigation is made space-aware: a newinboxSpaceFromPath+ per-space route maps in@posthog/core, auseInboxSpace()/useInboxRoutes()hook, and every tab, card, back-link and redirect resolves to the space you're in. Uses the realInboxItem(PR-review badge + Beta tag).Cmd+Iand the "open associated report" action are space-aware too./website/agents) — the agents subtree is forked (scouts + the agent-applications platform). A space-keyedAGENTS_ROUTEmap + auseAgentsRoutes()hook drive every link/navigate across the shared components (including the AI agent-builder's client tools)./website/customize) — a new page with its own secondary left sidebar (Skills · MCP servers), each rendering the shared view. Replaces the old standalone/website/skillsand/website/mcp-serversroutes.The route tree was regenerated and the
useAppViewactive-state mapping updated so highlighting works across both spaces.How did you test this?
@posthog/coretypecheck: clean@posthog/uitypecheck: clean@posthog/coretests: 1797 passed@posthog/uitests: 1096 passedAutomatic notifications
Created with PostHog Code