feat(command-center): choose folder when opening a terminal#3275
Conversation
When multiple folders are open, opening a terminal from the command center now prompts which folder to open it in. Falls back to the single / most-recent folder when there is only one. Generated-By: PostHog Code Task-Id: 196ab729-6bf1-4353-bf35-d21db2c9c190
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: 196ab729-6bf1-4353-bf35-d21db2c9c190
|
Reviews (1): Last reviewed commit: "style: format setTerminalCell signature" | Re-trigger Greptile |
| {step === "folder" ? ( | ||
| <Combobox.Content | ||
| items={folders} | ||
| getValue={(folder) => folder.name} |
There was a problem hiding this comment.
The folder picker filters only by
folder.name, but each item displays folder.path as its description. A user who spots a path they want and tries to type a fragment of it will see "No matching folders" even though the folder is visible in the list. Matching both name and path would make the search behave consistently with what users see.
| getValue={(folder) => folder.name} | |
| getValue={(folder) => `${folder.name} ${folder.path}`} |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Clean feature addition with correct URI-encoding for the colon-separator protocol and a test that validates the round-trip with a colon-containing path. The unresolved bot comment is a P2 UX suggestion (search filters by name but displays path), not a correctness or safety issue.
Problem
When multiple folders are open, opening a terminal from the command center silently opens it in whichever folder was accessed most recently, with no way to choose.
Changes
CleanShot.2026-07-08.at.11.49.18.mp4
How did you test this?
@posthog/corecommand-center unit tests (47 passed), including added round-trip tests for the terminal cell value encoding (id + optional cwd).Automatic notifications
Created with PostHog Code