fix(ui): send prompt on first click when switching branch#3277
Merged
Conversation
Switch branch was wrapped in AlertDialog.Action, which force-closed the dialog on click. That fired onOpenChange(false) -> onCancel(), wiping the pending message before the async checkoutBranch mutation resolved, so the prompt was silently dropped and the user had to send it again. Generated-By: PostHog Code Task-Id: 1040f7c6-d5ab-4994-9854-a7eaadf01a9a
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(ui): send prompt on first click when..." | Re-trigger Greptile |
charlesvien
added
the
Stamphog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking "Switch branch" on the branch-mismatch dialog switched the branch but didn't send the pending prompt, so it had to be sent again.
Changes
AlertDialog.Actionwrapper around "Switch branch". It force-closes the dialog on click, which firedonCancel()and wiped the pending message before the asynccheckoutBranchmutation resolved.handleCancelinuseBranchMismatchDialognow no-ops while a switch is in flight, so a dismiss during the async checkout can't drop the pending message.How did you test this?
pnpm --filter @posthog/ui test useBranchMismatchDialog-- 9/9 passing (added a test covering dismiss-during-switch).Automatic notifications
Created with PostHog Code