Skip to content

feat(models): support gpt-5.6 family#3310

Merged
charlesvien merged 1 commit into
mainfrom
posthog-code/add-gpt-5-6-models
Jul 9, 2026
Merged

feat(models): support gpt-5.6 family#3310
charlesvien merged 1 commit into
mainfrom
posthog-code/add-gpt-5-6-models

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Problem

OpenAI's GPT-5.6 preview family (gpt-5.6-sol, gpt-5.6-terra, gpt-5.6-luna) is rolling out 🚀

@trunk-io

trunk-io Bot commented Jul 9, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit fb200b0.

@tatoalo tatoalo force-pushed the posthog-code/add-gpt-5-6-models branch from fdedbec to c1d5e3e Compare July 9, 2026 15:14
@tatoalo tatoalo self-assigned this Jul 9, 2026
@tatoalo tatoalo marked this pull request as ready for review July 9, 2026 15:20
@greptile-apps

greptile-apps Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff (1)

  1. packages/agent/src/adapters/codex-app-server/models.test.ts, line 27-46 (link)

    P2 Missing label and direct-function test for supportsMaxEffort

    The values helper only extracts .value, so the .name field ("Max") is never asserted. The existing 'labels the extra tier "Extra High"' test covers this for xhigh; there is no parallel test for max. A typo in the name (e.g., "Maximum") would go undetected. Similarly, supportsXhighEffort has a dedicated describe block that directly imports and exercises the function, but supportsMaxEffort is not imported or directly tested — only covered indirectly through getReasoningEffortOptions.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (1): Last reviewed commit: "feat(models): support gpt-5.6 family wit..." | Re-trigger Greptile

@tatoalo tatoalo force-pushed the posthog-code/add-gpt-5-6-models branch from c1d5e3e to 34d9d06 Compare July 9, 2026 15:32
@tatoalo tatoalo changed the title feat(models): support gpt-5.6 family with sol-only max reasoning effort feat(models): support gpt-5.6 family Jul 9, 2026
@tatoalo tatoalo force-pushed the posthog-code/add-gpt-5-6-models branch 2 times, most recently from ed31c25 to 07ef83d Compare July 9, 2026 17:26
@tatoalo tatoalo force-pushed the posthog-code/add-gpt-5-6-models branch 2 times, most recently from 16fe387 to 824c089 Compare July 9, 2026 17:43
@tatoalo tatoalo force-pushed the posthog-code/add-gpt-5-6-models branch from 824c089 to fb200b0 Compare July 9, 2026 17:49
@tatoalo tatoalo added the Create Release This will trigger a new release label Jul 9, 2026
@charlesvien charlesvien merged commit 4271c9d into main Jul 9, 2026
31 checks passed
@charlesvien charlesvien deleted the posthog-code/add-gpt-5-6-models branch July 9, 2026 19:27
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Could not verify team-posthog-code membership (GitHub API error). Auto-release is limited to Team PostHog Code members, so this will ship with the next scheduled release instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Create Release This will trigger a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants