fix(bluebird): prefix channel name with # in CONTEXT.md empty state#3320
Merged
Merged
Conversation
The "No CONTEXT.md yet" empty state referred to the channel by its bare name in bold. Everywhere else in the Channels/Website space a channel is written as #channel (breadcrumbs, welcome heading, context tabs), so add the missing # prefix to match. Generated-By: PostHog Code Task-Id: 73205374-7414-44fb-9815-52d8bab1ebab
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(bluebird): prefix channel name with ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Why: In the Project Bluebird (Channels/Website space) UI, the "No CONTEXT.md yet" empty state showed the channel name in bold but without the
#prefix, unlike every other place a channel is referenced.Changes
Added the
#prefix (inside the existing bold) to the channel name in the CONTEXT.md empty state, so it reads#channel— matching the convention used in breadcrumbs, the channel welcome heading, and the context tabs.How did you test this?
No automated tests were run — this is a one-character copy change to JSX prose in the empty state (no test asserts this string). Verified by inspection and against the
#${channelName}convention used elsewhere inpackages/ui.Automatic notifications
Created with PostHog Code