fix(agent): stop double-loading .claude/skills as synthetic plugins#3351
Closed
MattPua wants to merge 1 commit into
Closed
fix(agent): stop double-loading .claude/skills as synthetic plugins#3351MattPua wants to merge 1 commit into
MattPua wants to merge 1 commit into
Conversation
The Claude Agent SDK already auto-loads ~/.claude/skills and <repoPath>/.claude/skills natively as @skills-dir plugins. Wrapping them again in synthetic user-skills/repo-skills-<hash> plugins made every skill show up twice in the session's skill list. Generated-By: PostHog Code Task-Id: bd56bbcd-cc4e-4d96-9913-0ff3c22968a5
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skills in
.claude/skillsshowed up twice in the session skill list: once bare (e.g.canvas-templates) and once under a synthetic plugin prefix (e.g.repo-skills-<hash>:canvas-templates). Same for~/.claude/skillsunderuser-skills:.Changes
The Claude Agent SDK already auto-loads
~/.claude/skillsand<repoPath>/.claude/skillsnatively as@skills-dirplugins.discover-plugins.tswas additionally symlinking those same directories into syntheticuser-skills/repo-skills-<hash>plugins, so every skill loaded twice under two different names. RemoveddiscoverUserSkills/discoverRepoSkills— only sources the SDK can't see on its own (marketplace-installed plugins, the user's Codex skills dir) still need manual discovery.How did you test this?
npx vitest run packages/workspace-server/src/services/agent/discover-plugins.test.ts— updated tests pass.pnpm --filter @posthog/workspace-server typecheck— no new errors (2 pre-existing unrelated failures confirmed present onmaintoo).biome checkon touched files — clean.Automatic notifications
Created with PostHog Code