fix(flags): local eval dependency fail to match#734
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-07-10 02:53:56 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Under local evaluation a release condition of the form "flag X evaluates to
false" never matched, so the dependent flag returnedfalsefor every locally evaluated user. The chain walk inevaluate_flag_dependencyrejected any falsy flag in the chain before the value comparison ran, and since the referenced flag is always last in the chain the users whose flag X wasfalse(exactly the ones the condition should match) were dropped.This reworks the chain walk to only evaluate and cache each member and to decide the outcome solely from the referenced flag's cached value, matching the Go and C# SDKs and the Rust
/flagsservice. A malformedvalue: nullcondition now falls back to the server instead of silently returningtrue.💚 How did you test it?
Added end to end tests in
posthog/test/test_feature_flags.pycoveringvalue: falsewith variant andtruecontrols, the multi level A/B/D chain, an inactive base flag, an inconclusive base that falls back to/flags, andvalue: null. Reran the bug report reproduction and the full suite passes.📝 Checklist
If releasing new changes
sampo addto generate a changeset file