sql.mk: remove now-dead conditional installcheck:install guard

[jnasbyupgrade]

Stacked on #58 (pgxntool 2.3.0 sync).

The ifneq ($(TEST_EXISTING_DEPLOY),pgtle) installcheck: install endif guard added in #51 to fix issue #79 (installcheck running before install) is now dead code: pgxntool 2.3.0 fixed #79 upstream by making installcheck unconditionally depend on install directly in base.mk, so this file's conditional edge has no effect either way -- base.mk's own unconditional edge fires regardless. The pg_tle-mode side effect that guard was meant to prevent (writing cat_tools.control to the real extension directory) is now handled instead by redirecting install's writes to a scratch DESTDIR in bin/test_existing (also part of #58).

Verified make test and make verify-results still pass without it.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e9c8d375-fbf9-4191-9cd2-83101fe8ad22

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

[github-actions]

Code review

No issues found in the diff itself — the removal of the dead ifneq ($(TEST_EXISTING_DEPLOY),pgtle) installcheck: install endif guard in sql.mk is a clean, self-contained deletion (verified against pgxntool/base.mk's now-unconditional installcheck: install edge and bin/test_existing's DESTDIR redirection for pgtle mode).

One note on the PR description itself: per CLAUDE.md § "Pull request descriptions", the opening should "lead with the substantive change and why," keeping incidental content out of the opening, since the maintainer builds the squash commit message directly from it. The current opening line, "Stacked on #58 (pgxntool 2.3.0 sync).", is dependency bookkeeping rather than the substantive change — the actual explanation starts in the second paragraph. Moving the stacking note below the substantive explanation (or omitting it, since GitHub already surfaces the stacked-PR relationship) would make the opening match the intended commit-message content.