sql.mk: remove now-redundant historical_installs derivation - #61
Open
jnasbyupgrade wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
pgxntool issue Postgres-Extensions#48 (filed citing cat_tools' own workaround as an example) was that base.mk's DATA wildcard only matched sql/*--*--*.sql (upgrade scripts, two dashes), silently skipping historical single-dash full-install scripts like sql/cat_tools--0.1.0.sql. pgxntool 2.3.0 fixed this by widening the wildcard to sql/*--*.sql, which matches both. Our historical_installs variable was a generalized version of that exact workaround (deriving the committed, non-.sql.in-backed cat_tools--0.1.*.sql files), now fully superseded: base.mk's own DATA wildcard already includes them at parse time, since these files are committed directly and are always present regardless of build state (unlike the generated versioned/upgrade files, which is a separate, still-needed derivation here for a different reason -- cat_tools issue Postgres-Extensions#28's two-phase-make timing gap, unaffected by pgxntool's dash-count fix). Verified on a truly clean tree (make clean, only committed .sql present): make -s print-DATA lists all 8 historical cat_tools--0.1.*.sql files without this derivation, make install places them in the real extension directory, and make test / verify-results / test-update all still pass.
jnasbyupgrade
force-pushed
the
cleanup-historical-installs-redundancy
branch
from
August 1, 2026 22:38
f9d2585 to
b701538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #58 (pgxntool 2.3.0 sync).
pgxntool issue #48 -- filed citing cat_tools' own workaround (`DATA += sql/cat_tools--0.2.1.sql`) as one of two known examples -- was that `base.mk`'s `DATA` wildcard only matched `sql/----.sql` (upgrade scripts, two dashes), silently skipping historical single-dash full-install scripts like `sql/cat_tools--0.1.0.sql`. pgxntool 2.3.0 fixed this by widening the wildcard to `sql/--*.sql`, matching both.
Our `historical_installs` variable was a generalized version of that exact workaround (deriving the committed, non-`.sql.in`-backed `cat_tools--0.1.*.sql` files), now fully superseded: `base.mk`'s own `DATA` wildcard already includes them at parse time, since these files are committed directly and always present regardless of build state. This is unlike the generated versioned/upgrade files -- that derivation (`versioned_out`/`upgrade_scripts_out`) stays, since it exists for a different, still-open reason (cat_tools issue #28's two-phase-make timing gap, unaffected by pgxntool's dash-count fix).
Verified on a truly clean tree (`make clean`, only committed `.sql` present): `make -s print-DATA` lists all 8 historical `cat_tools--0.1.*.sql` files without this derivation, `make install` places them in the real extension directory, and `make test`/`verify-results`/`test-update` all still pass.