claude-code-review.yml: register the inline-comment MCP server via claude_args - #62
Merged
jnasbyupgrade merged 1 commit intoAug 1, 2026
Conversation
…aude_args The workflow invokes claude-code-action with an explicit prompt (agent mode, no @claude mention). In agent mode the action only installs the github_inline_comment MCP server when it sees mcp__github_inline_comment__create_inline_comment listed in a --allowedTools flag inside claude_args -- it does not read the code-review plugin's own allowed-tools frontmatter to decide that. Since claude_args was never set, the MCP server never started, so mcp__github_inline_comment__create_inline_comment did not exist as a callable tool. This made every review since the plugin switch fall back to one consolidated PR comment ("inline line comments were not available in this environment") instead of real per-line comments, e.g. Postgres-Extensions#58 (comment) Confirmed by reading claude-code-action's source (src/mcp/install-mcp-server.ts's prepareMcpConfig and src/modes/agent/parse-tools.ts's parseAllowedTools): this repo's pull_request_target design (see .github/workflows/CLAUDE.md) means the fix can only be verified from a subsequent PR after this merges to master, since GitHub always runs a pull_request_target workflow file from the base branch.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow invokes claude-code-action with an explicit prompt (agent mode, no @claude mention). In agent mode the action only installs the github_inline_comment MCP server when it sees mcp__github_inline_comment__create_inline_comment listed in a --allowedTools flag inside claude_args -- it does not read the code-review plugin's own allowed-tools frontmatter to decide that. Since claude_args was never set, the MCP server never started, so mcp__github_inline_comment__create_inline_comment did not exist as a callable tool. This made every review since the plugin switch fall back to one consolidated PR comment ("inline line comments were not available in this environment") instead of real per-line comments, e.g. #58 (comment)
Confirmed by reading claude-code-action's source (
src/mcp/install-mcp-server.ts'sprepareMcpConfigandsrc/modes/agent/parse-tools.ts'sparseAllowedTools).Test plan
.github/workflows/CLAUDE.md, apull_request_targetworkflow always runs the file version on the base branch, so this PR's ownclaude-reviewcheck cannot prove the fix took effect -- verify on the next PR after this merges to master (look for real inline comments instead of a single consolidated one)