Skip to content

Add coverage for PGXNTOOL_ENABLE_FS_INSTALL / PGXNTOOL_ENABLE_PGXN_INSTALL - #70

Draft
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:issue-55-fs-install
Draft

Add coverage for PGXNTOOL_ENABLE_FS_INSTALL / PGXNTOOL_ENABLE_PGXN_INSTALL#70
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:issue-55-fs-install

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

Summary

  • Adds BATS coverage for pgxntool PR Add PGXNTOOL_ENABLE_FS_INSTALL and PGXNTOOL_ENABLE_PGXN_INSTALL pgxntool#91, which adds PGXNTOOL_ENABLE_FS_INSTALL (gates install out of test/verify-results/installcheck/test-build, for existing-mode/pg_tle-style testing -- issues util.sh: micro-optimize array_not_empty comparison #55, #90) and PGXNTOOL_ENABLE_PGXN_INSTALL (independently gates pgtap's own pgxn install --sudo auto-install, defaulting to follow PGXNTOOL_ENABLE_FS_INSTALL).
  • Extends test/standard/make-test.bats: default/override/independent-override behavior, structural proof via make -p -n that install/pgtap prerequisites are genuinely removed, a dry-run proof (fake DESTDIR) that the pgxn install pgtap --sudo recipe disappears when disabled, and end-to-end proof that make test PGXNTOOL_ENABLE_FS_INSTALL=no succeeds against an already-installed tree but fails against a genuinely uninstalled one.
  • Also tightens two installcheck prerequisite-list assertions (the pre-existing issue #79 one and the new one) to match the exact install token instead of a grep -w substring, which false-matched inside the unrelated test/install/schedule path.

Test plan

  • test/standard/make-test.bats (35/35 passed)
  • Full test-all suite (257/257 passed, 0 skipped)

…STALL

Add tests/updates for pgxntool commit 6966d3c (adds PGXNTOOL_ENABLE_FS_INSTALL /
PGXNTOOL_ENABLE_PGXN_INSTALL):
- `install` is now conditionally gated out of `test`/`verify-results`/
  `installcheck`/`test-build` via `PGXNTOOL_ENABLE_FS_INSTALL`, for
  existing-mode/pg_tle-style testing (issues Postgres-Extensions#55, #90)
- pgtap's own `pgxn install --sudo` auto-install is independently gated via
  `PGXNTOOL_ENABLE_PGXN_INSTALL`, defaulting to follow
  `PGXNTOOL_ENABLE_FS_INSTALL`

Extends `test/standard/make-test.bats` with: default/override/independent-
override behavior (via `print-%`); structural proof via `make -p -n` that
`install`/`pgtap` prerequisites are genuinely removed from `installcheck`'s
parsed rule, not just skipped at runtime; a dry-run proof (via a fake
`DESTDIR`) that the `pgxn install pgtap --sudo` recipe disappears when
disabled; and end-to-end proof that `make test PGXNTOOL_ENABLE_FS_INSTALL=no`
succeeds against an already-installed tree but fails against a genuinely
uninstalled one. Also tightens two `installcheck` prerequisite-list
assertions (the pre-existing issue #79 one and the new one) to match the
exact `install` token instead of a `grep -w` substring, which false-matched
inside the unrelated `test/install/schedule` path.

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2f3f37b4-aaff-4004-a6ed-8bb63e37ac16

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant