Repository navigation
abi-diff --asm: assembly-level triage of every target; findings 40-43 - #36
Merged
Merged
Conversation
…erences; triage of every target; findings 40-43 Each generated function stores its parameters to extern volatile globals and returns a volatile load; both sides are compiled to MIR after instruction selection by their own backend (rustc -Cllvm-args=-stop-after=finalize-isel, clang -mllvm -stop-after=finalize-isel, clang given rustc's FPU, soft-float ABI and relocation model) and the incoming registers, stack slots and return registers are compared. Validated on the main targets (finding 20 differs, findings 19 and #163911 keep their placement, nothing else differs; the ppc64 inreg float is equivalent). --all, seeds 1-3: thousands of IR differences are equivalent; what remains is classified in docs/checks.md. Findings: 40 mips64 narrow integer arguments lose signext/zeroext (regression from #163653), 41 thumbv7a Windows homogeneous float aggregates not in VFP registers, 42 32-bit PowerPC BSDs return small structs through memory, 43 m68k repr(C) alignment of i64/f64. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXiEXbESemwqMLYKaWLDbT
… from a plain extern "C" return of an align(32) struct, since 1.90.0) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXiEXbESemwqMLYKaWLDbT
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mirth-lab abi-diff --asmdecides the IR-level differences that abi-diff reports by checking where each argument and the return value actually end up.-Cllvm-args=-stop-after=finalize-isel(its--emit=asmoutput is then MIR).-mllvm -stop-after=finalize-isel.-mfpu), soft-float ABI (-mabi=aapcs-soft) and relocation model (-fPIC/-fno-pic).signext/zeroextdifference on an integer narrower than a register stays a finding, because placement cannot show an extension contract.Validation on the 21 main targets
inregfloat, previously labelled "needs a run", has the same placement in all 40 cases, so it is equivalent.--asm) produces the same output as before.--asm --all, seeds 1–3, 312 targetsaapcs-soft;$t9.docs/checks.md. Each class gets a verdict and the evidence for it; GCC behaviour cited from source or documentation is marked as not run.Findings (facts only, under
docs/hunt/)extern "C"arguments losesignext/zeroext, so a Rust caller no longer extends them (sll/sebreplaced bynop). Regression from #163653, merged 2026-10-04: nightly-2026-07-18 and 1.98.0 are fine, nightly-2026-10-06 is affected.eabihftargets.repr(C)alignment ofi64is 4 and off648, where GCC's documented default is 2.Other results:
extern "C"return of analign(32)struct since 1.90.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01QXiEXbESemwqMLYKaWLDbT