Repository navigation
mirth's own checks over the corpus: --compiler-checks, ui-incr (P6 over the UI suite); finding 56 - #42
Merged
Conversation
…piler-checks (diag-check, gate-mutate), and ui-incr (P6 over the UI corpus with the reuse check); known untracked reads and reuse reports in rustc/ Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXiEXbESemwqMLYKaWLDbT
…ect names removed, reuse-check re-emissions told from duplicates; known reuse reports; finding 56 (-Zunleash: an incremental rebuild drops the warning and the feature-gate error); fourth batch in checks.md Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QXiEXbESemwqMLYKaWLDbT
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of leaning on mirth more: the patched compiler's own checks (
verify-reuse.patchandreport-untracked.patchinrustc-verify12) had only run in the fuzzer, the replays and the flag walks. This PR turns them on over the corpus.What's added
--compiler-checksfor the sweep driver; used by diag-check and gate-mutate.RUSTC_VERIFY_REUSE=allandRUSTC_REPORT_UNTRACKED. Both checks hook the dependency graph, so they do nothing without-Cincremental.rustc/untracked-known.tsv: every (what, file) pair the fuzzer, replays and flag walks reported, plus options whose verdict holds anywhere. Reuse reports are classified againstrustc/reuse-known.txt.compiler_checks.rs, plusCompile::compiler_checks.mirth-lab ui-incr: P6 over the UI corpus.big-run.shrunsdiag-check-ccandui-incr.Results
ui-incrdiag-check --compiler-checksgate-mutate --compiler-checksFinding 56. With
-Zunleash-the-miri-inside-of-you, the flag's warning and its feature-gate error come from session state that const checking fills as a side effect. An incremental rebuild therefore drops both, and accepts a crate that a clean build rejects. Low severity: the flag exists for testing the const evaluator. The lost warning goes back to at least 1.80.0; the error case was shown on nightly-2026-10-06. Facts are indocs/hunt/unleash-incremental.md, with a repro indocs/hunt/tests/.Triaged, not findings (details in
checks.md, fourth batch):shadow-mode.md.--cap-lints;release-diff is not wired in, because it builds with official toolchains that don't have the patches.
Note: this branch numbers its finding 56. If another branch merges first, it may need renumbering.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QXiEXbESemwqMLYKaWLDbT