Repository navigation
Preserve original sshdconfig validation diagnostics - #1807
Merged
Steve Lee (SteveL-MSFT) merged 1 commit intoNov 14, 2026
Merged
Steve Lee (SteveL-MSFT) merged 1 commit into
Steve Lee (SteveL-MSFT) merged 1 commit into
Conversation
Stop reporting missing host keys and permission failures as an elevation requirement. Add diagnostic regression coverage and document host-key setup and troubleshooting. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change preserving SSHD validation diagnostics.
No open issues 🎉
What changed in this PR
Addresses #1806 by preserving OpenSSH validation diagnostics in the SSHD configuration resource instead of replacing host-key and permission errors with a generic elevation message. Failed validation still blocks the operation.
Changes:
- Preserve original diagnostics through the existing command-error path.
- Add regression tests for failure diagnostics and successful output.
- Document host-key prerequisites, initialization, and permission troubleshooting.
| File | Description |
|---|---|
| resources/sshdconfig/src/util.rs | Extracts output parsing, removes diagnostic replacement, and adds regression tests. |
| resources/sshdconfig/locales/en-us.toml | Removes the unused generic elevation message. |
| docs/reference/resources/Microsoft/OpenSSH/SSHD/sshd_config/index.md | Documents host-key requirements and validation troubleshooting. |
Review effort: Balanced
Steve Lee (SteveL-MSFT)
deleted the
stevel-msft-sshdconfig-elevation-error
branch
November 14, 2026 00:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sshdconfig reports "elevated security context required" for both missing host keys and permission failures from
sshd -T, hiding the actual failure even when DSC is elevated.Preserve the complete original OpenSSH diagnostic through the existing command-error path. Validation behavior stays unchanged: no automatic key generation, service startup, permission changes, or bypass of failed validation. Add focused regression coverage and document host-key initialization and troubleshooting.
Validation
build.ps1build and Clippy passed.sshdis now installed, this session is not elevated;sshd -Talso reports a missing default configuration. Full OpenSSH integration coverage remains unverified.Fixes: #1806