Repository navigation
(GH-1495) Experimental SSH subsystem for DSC - #1810
Draft
Gijs Reijn (Gijsreyn) wants to merge 1 commit into
Draft
Gijs Reijn (Gijsreyn) wants to merge 1 commit into
Gijs Reijn (Gijsreyn) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This change:
--target ssh://[user@]host[:port]option to rundsc config get,set,testandexporton another machine.ssh_subsystem.dsc.yamlconfiguration that registersdsc serveras thedscSSH subsystem on the target.dscwith its version, and adds the equivalent CLI exit code toinvoke_dsc_configerrors.PR Context
#1495 asks for a way to apply a configuration to a machine without copying files to it or wrapping
dscin a remote shell command. The target already has what's needed:dsc serverspeaks MCP over standard input and output, andsshdcan start it as a subsystem.With
--target,dscreads the document and parameters on the client, starts the systemsshclient with thedscsubsystem, calls theinvoke_dsc_configtool once, and prints the result as a local run does. Nothing has to exist on the target exceptdscand the subsystem entry.Remarks on the design
sshclient. Authentication, host keys, jump hosts and~/.ssh/configaliases work as they do forssh. DSC handles no credentials. A password in the URI is rejected, and port and user are left tosshwhen the URI has none.configoperations,--system-root, and a target that isn't a plainssh://URI fail as invalid arguments, so an unsupported combination never opens a connection.dsc3.4.0-preview.3or newer. Older servers ignore arguments they don't know, so--what-ifwould apply changes for real.11, with whatsshwrote on standard error.--trace-format json. The client emits those traces through its own tracing settings, prefixed with the host.Microsoft.DSC/Includegets a warning that file paths are resolved on the target, not on the client.DSC_SSH_EXECUTABLE. Replaces thesshfound onPATH. The tests use it to run against a stand-in client.dsc resourcecommands, multiple targets in one run, and reference docs and a changelog entry, which wait on the RFC.