Repository navigation
Preserve relative indentation in comment runs - #2236
Merged
Christoph Bergmeister (bergmeister) merged 2 commits intoOct 26, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code for review comment in pull request
Preserve relative indentation in comment runs
Oct 26, 2026
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2237
October 26, 2026 10:42
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized change addresses the indentation loss with regression coverage for both indentation styles and no unresolved findings.
No open issues 🎉
What changed in this PR
This PR updates the indentation rule to preserve relative spacing within contiguous comment runs, even when the first comment is not the least-indented.
Changes:
- Calculate comment offsets from the least-indented line in the full run.
- Add regression cases for space and tab indentation.
| File | Description |
|---|---|
Tests/Rules/UseConsistentIndentation.tests.ps1 |
Adds space- and tab-indented regression cases with a more-indented first comment. |
Rules/UseConsistentIndentation.cs |
Uses the run’s minimum starting column as the shared indentation baseline. |
Review effort: Balanced
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 26, 2026 11:18
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 26, 2026 11:18
Christoph Bergmeister (bergmeister)
merged commit Oct 26, 2026
0c2d630
into
copilot/fix-psuseconsistentindentation-issue
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-code-based-on-review-comment
branch
October 26, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment runs lost relative indentation when correction clipped each comment line independently. Apply a shared shift constrained by the run’s least-indented line.