Repository navigation
Preserve comment indentation after pipelines with PipelineIndentation=None - #2241
Merged
Christoph Bergmeister (bergmeister) merged 3 commits intoOct 26, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code issue raised in review comment
Preserve comment indentation after pipelines with PipelineIndentation=None
Oct 26, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression fixture contains an unfinished pipeline, producing a parse-error diagnostic that fails its empty-diagnostics assertion.
1 open issue
What changed in this PR
This PR updates the indentation rule to preserve an entire comment run after a pipe when PipelineIndentation=None, keeping relative comment indentation intact.
Changes:
- Detect whether a comment run starts after a pipe and skip indentation corrections for the full run.
- Add analyzer and formatter regression assertions for differently indented comments.
| File | Description |
|---|---|
| Tests/Rules/UseConsistentIndentation.tests.ps1 | Adds regression coverage for preserving comment-run indentation. |
| Rules/UseConsistentIndentation.cs | Detects pipeline-prefixed comment runs and preserves their indentation with None. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 26, 2026 21:44
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 26, 2026 21:44
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2242
October 26, 2026 21:44
Christoph Bergmeister (bergmeister)
merged commit Oct 26, 2026
b028aaf
into
copilot/fix-psuseconsistentindentation-issue
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-review-comment-2231
branch
October 26, 2026 21:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

With
PipelineIndentation=None, only the first standalone comment after a pipe was skipped; later comments in the same run could be flattened, losing their relative indentation.