Skip to content

fix: client authentication - #127

Merged
pbrassel merged 2 commits into
mainfrom
fix/client-auth
Jul 28, 2026
Merged

fix: client authentication#127
pbrassel merged 2 commits into
mainfrom
fix/client-auth

Conversation

@pbrassel

@pbrassel pbrassel commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added support for configuring client authentication methods and token binding when creating or updating clients.
    • Client details now display the selected authentication and token-binding settings.
  • Bug Fixes

    • Client authentication flow validation now runs as a standard test.
  • Documentation

    • Updated the code coverage badge from 97% to 98%.

pbrassel added 2 commits July 28, 2026 13:02
…odels

The authentication method of new clients will automatically default to `"secret"` which was the behavior in older versions.
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f537ccf-074b-40c0-99be-4e8d34004449

📥 Commits

Reviewing files that changed from the base of the PR and between a2e3fd2 and 983938b.

📒 Files selected for processing (3)
  • README.md
  • flame_hub/_auth_client.py
  • tests/test_flow.py
💤 Files with no reviewable changes (1)
  • tests/test_flow.py

📝 Walkthrough

Walkthrough

Client authorization and token binding methods are added to client models and AuthClient create/update APIs. The client authentication flow test is enabled, and the README coverage badge is updated.

Changes

Client authorization methods

Layer / File(s) Summary
Authorization model contracts
flame_hub/_auth_client.py
Defines literal types for authentication and token binding methods and adds them to create, client, and update models.
Authorization API propagation
flame_hub/_auth_client.py, tests/test_flow.py, README.md
Extends client creation and update signatures and payloads, enables the client authentication test, and updates the coverage badge.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the main change to client authentication behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/client-auth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pbrassel
pbrassel merged commit 425c032 into main Jul 28, 2026
7 checks passed
@pbrassel
pbrassel deleted the fix/client-auth branch July 28, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant