[WIP] Isolate FormRecordList modal validations - #1924
Open
sanjacornelius wants to merge 1 commit into
Open
Conversation
Prevent record-list modal fields from affecting parent screen validation. Add NoOpValidations and return it for FormRecordList in ValidationsFactory so modal fields are not included in parent validation rules. Add an "isolated" prop to vue-form-renderer to stop modal renderers from propagating validation updates to the parent, and set isolated=true for add/edit renderers in form-record-list.
screen-builder
|
||||||||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
bugfix/FOUR-32292
|
| Run status |
|
| Run duration | 10m 08s |
| Commit |
|
| Committer | Sanja |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
0
|
|
|
19
|
|
|
0
|
|
|
388
|
| View all changes introduced in this branch ↗︎ | |
Tests for review

tests/e2e/specs/DefaultValues.spec.js • 1 failed test • CI - Chrome
| Test | Artifacts | |
|---|---|---|
| Default values > Javascript default value |
Test Replay
Screenshots
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent record-list modal fields from affecting parent screen validation. Add NoOpValidations and return it for FormRecordList in ValidationsFactory so modal fields are not included in parent validation rules. Add an "isolated" prop to vue-form-renderer to stop modal renderers from propagating validation updates to the parent, and set isolated=true for add/edit renderers in form-record-list.
Issue & Reproduction Steps
Expected behavior:
Actual behavior:
Solution
How to Test
Test the steps above
Related Tickets & Packages
Code Review Checklist