Skip to content

[WIP] Isolate FormRecordList modal validations - #1924

Open
sanjacornelius wants to merge 1 commit into
developfrom
bugfix/FOUR-32292
Open

[WIP] Isolate FormRecordList modal validations#1924
sanjacornelius wants to merge 1 commit into
developfrom
bugfix/FOUR-32292

Conversation

@sanjacornelius

Copy link
Copy Markdown
Contributor

Prevent record-list modal fields from affecting parent screen validation. Add NoOpValidations and return it for FormRecordList in ValidationsFactory so modal fields are not included in parent validation rules. Add an "isolated" prop to vue-form-renderer to stop modal renderers from propagating validation updates to the parent, and set isolated=true for add/edit renderers in form-record-list.

Issue & Reproduction Steps

Expected behavior:

Actual behavior:

Solution

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Prevent record-list modal fields from affecting parent screen validation. Add NoOpValidations and return it for FormRecordList in ValidationsFactory so modal fields are not included in parent validation rules. Add an "isolated" prop to vue-form-renderer to stop modal renderers from propagating validation updates to the parent, and set isolated=true for add/edit renderers in form-record-list.
@cypress

cypress Bot commented Aug 3, 2026

Copy link
Copy Markdown

screen-builder    Run #2319

Run Properties:  status check failed Failed #2319  •  git commit 6ba7254b12: [WIP] Isolate FormRecordList modal validations
Project screen-builder
Branch Review bugfix/FOUR-32292
Run status status check failed Failed #2319
Run duration 10m 08s
Commit git commit 6ba7254b12: [WIP] Isolate FormRecordList modal validations
Committer Sanja
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 388
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/e2e/specs/DefaultValues.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Default values > Javascript default value Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant