Skip to content

tests(inferers): remove dead TEST_CASE_ERROR_10 variable - #9031

Merged
ericspod merged 3 commits into
Project-MONAI:devfrom
aymuos15:fix/dead-case-variable
Sep 26, 2026
Merged

ericspod merged 3 commits into
Project-MONAI:devfrom
aymuos15:fix/dead-case-variable

Conversation

@aymuos15

Copy link
Copy Markdown
Contributor

Description

Removes TEST_CASE_ERROR_10 from tests/inferers/test_patch_inferer.py. This variable was assigned but never referenced: the error-cases parameterized expand list uses only ERROR_0 through ERROR_9, and grepping the module confirms it has no readers beyond its own definition. It was also byte-identical to TEST_CASE_ERROR_7.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

…AI#44)

TEST_CASE_ERROR_10 was assigned but never referenced in any parameterized expand list. Confirmed by grepping the module — single hit at its own definition.

Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The patch inferer error tests no longer define or parameterize TEST_CASE_ERROR_10, which covered a merger missing merged_shape. Error cases TEST_CASE_ERROR_0 through TEST_CASE_ERROR_9 remain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, specific, and accurately describes removing the dead TEST_CASE_ERROR_10 test variable.
Description check ✅ Passed The description follows the template closely with a clear summary and types-of-changes section, though the issue reference line is omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ericspod
ericspod enabled auto-merge (squash) September 26, 2026 12:13
@ericspod
ericspod disabled auto-merge September 26, 2026 12:13
@ericspod
ericspod enabled auto-merge (squash) September 26, 2026 12:13
@ericspod
ericspod merged commit 25847e7 into Project-MONAI:dev Sep 26, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants