fix(sql): preserve nested temporal aggregates - #372
Merged
Conversation
zzylol
force-pushed
the
feat/sql-temporal-histogram
branch
from
September 10, 2026 17:42
c94370d to
b3dc404
Compare
zzylol
force-pushed
the
fix/sql-nested-aggregate-pr371
branch
from
September 10, 2026 17:48
984897f to
e59b1be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An outer SQL aggregate could hide an otherwise reusable inner temporal aggregate, forcing the complete nested expression through exact execution.
What
How
Recursive lowering retains the inner aggregate node instead of flattening its output into an opaque leaf. The outer operator consumes the finalized readable values from that child, preserving the maintenance/read boundary.
Before
SUM(asap_rate(...))became one exact residual subtree.After
The rate state can be precomputed and reused, while the outer sum executes over its readout in the same DAG.
Verification
cargo fmt --all -- --checkcargo test -p asap-integration-tests --test sql_to_post_asap(11/11)