refactor(planner): use post-ASAP IDs for lifecycle deployments - #376
Merged
Conversation
zzylol
force-pushed
the
refactor/canonical-lifecycle-wire
branch
from
September 10, 2026 14:01
f146b57 to
7d114d8
Compare
zzylol
force-pushed
the
refactor/lifecycle-dag-identity
branch
from
September 10, 2026 14:01
1868908 to
c72e3b7
Compare
zzylol
force-pushed
the
refactor/canonical-lifecycle-wire
branch
from
September 10, 2026 14:02
7d114d8 to
a348a12
Compare
zzylol
force-pushed
the
refactor/lifecycle-dag-identity
branch
from
September 10, 2026 14:03
c72e3b7 to
b9930dc
Compare
zzylol
force-pushed
the
refactor/canonical-lifecycle-wire
branch
from
September 10, 2026 15:57
a348a12 to
4a666cb
Compare
zzylol
force-pushed
the
refactor/lifecycle-dag-identity
branch
2 times, most recently
from
September 10, 2026 16:07
f734b79 to
db57b83
Compare
zzylol
changed the base branch from
refactor/canonical-lifecycle-wire
to
main
September 10, 2026 16:08
zzylol
force-pushed
the
refactor/lifecycle-dag-identity
branch
from
September 10, 2026 16:08
db57b83 to
c8226f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifecycle deployments used a second SummaryAgg-only ordinal named
summary_index, even though the post-ASAP DAG already assigns each semantic node a typed identity. That ordinal could not be safely compared with graph node IDs. The lifecycle result also called a provider window implementation key a physical deployment ID, crossing the backend ownership boundary.This derives every lifecycle deployment's real
PostAsapNodeIdfrom the same DAG compilation and removes the duplicate ordinal. It renames the planner field toselected_window_implementation_id; the existing JSON field name remains as a documented compatibility adapter until the export receives a version bump. This identity remains scoped to one plan and is deliberately distinct from bothSummaryDefinitionIdandSummaryInstanceId; noSIDalias is introduced.Stacked on #375.
Validation:
CARGO_INCREMENTAL=0 cargo check -p asap-aware-mapping --lib(the focused tests passed before this identity-only change; a subsequent local test build was blocked by host disk exhaustion).