Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
CUDA build/runtime validation was unavailable and requires final CI or human verification.
Pull request overview
Fixes self-play initialization by loading configured checkpoints before training and synchronizing asynchronous rollout actors.
Changes:
- Loads
base.load_model_pathbefore self-play setup. - Seeds the initial self-play checkpoint from loaded weights.
- Synchronizes async actor parameters after policy loading.
File summaries
| File | Description |
|---|---|
src/pufferl.cu |
Implements checkpoint loading and asynchronous actor synchronization. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base.load_model_pathbefore training starts.Fixes #618.
Related: #632 was an earlier closed attempt from another contributor. This PR independently applies the same narrow load-order fix to the current
5chead.Validation
git diff --checkpassed.