Repository navigation
v1 CLARIOstar: refuse to close the drawer on a plate too tall for it - #1529
Merged
BioCam merged 1 commit intoOct 22, 2026
Merged
Conversation
BioCam
force-pushed
the
bmg-clariostar-v1-drawer-plate-height
branch
from
October 22, 2026 15:38
7972053 to
3310b27
Compare
BioCam
marked this pull request as ready for review
October 22, 2026 17:15
- `Drawer.close()` checks the plate on the plate holder, its lid included, against `_maximum_plate_size_z` (20 mm) before anything is sent, and raises `ValueError` if it is taller; with no plate it closes as before. - Placing a plate is not checked: a tall plate can stand on the open drawer. - `stop()` raises the same error and leaves the drawer and the connection open. - Quit codes 242 and 243 are named: the wellplate sensor failed, or no wellplate is inserted or the focal height is too low for the one detected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BioCam
force-pushed
the
bmg-clariostar-v1-drawer-plate-height
branch
from
October 22, 2026 17:23
3310b27 to
930a171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
Closing the v1 CLARIOstar's drawer carries whatever stands on the plate holder into the CLARIOstar, however tall it is. The plate holder accepts any plate while the drawer is out, so a deep-well plate (about 43.5 mm) or a plate with a tall lid is closed into the CLARIOstar as readily as a standard 14.35 mm wellplate, and nothing stops it before the drawer moves. The CLARIOstar's own wellplate sensor reads the plate only once it is already travelling in. And when the CLARIOstar refuses a command over its wellplate sensor (quit codes 242 and 243), the error names no reason.
PR Content
Drawer.close()checks the plate on the plate holder, its lid included, againstDrawer._maximum_plate_size_z(20 mm) before anything is sent, and raisesValueErrornaming the plate and both heights if it is taller. With no plate on the holder it closes as before.stop()raises the same error instead of closing the drawer over the plate; the drawer and the connection stay open.🤖 Generated with Claude Code