Repository navigation
Conversation
- `Drawer.close()` checks the plate on the plate holder, its lid included, against `_maximum_plate_size_z` (20 mm) before anything is sent, and raises `ValueError` if it is taller; with no plate it closes as before. - Placing a plate is not checked: a tall plate can stand on the open drawer. - `stop()` raises the same error and leaves the drawer and the connection open. - Quit codes 242 and 243 are named: the wellplate sensor failed, or no wellplate is inserted or the focal height is too low for the one detected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The simulated reader reads fluorescence (several fluorescence channels, matrix scans) and luminescence as random counts within the detector's range, or replays earlier results given as `simulated_data`; spectra, filter detection and z-profiles raise NotImplementedError. - A read's checks and RUN parameters are in one method the simulator reuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BioCam
marked this pull request as ready for review
October 22, 2026 19:00
BioCam
deleted the
bmg-clariostar-v1-simulated-fluorescence-luminescence
branch
October 22, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
A simulated v1 CLARIOstar sets up, moves its drawer, controls its temperature and reads absorbance, but has no fluorescence or luminescence (
clariostar.fluorescenceandclariostar.luminescenceare None): a protocol that reads fluorescence or luminescence cannot be run, tested or demonstrated without the device. And nothing checks such a protocol's reads before hardware: a fluorescence channel, gain or focal height the device would refuse only shows up on the device.PR Content
CLARIOstarPlus(simulation=True)reads fluorescence (one or several fluorescence channels, from the top or the bottom optic, in flying mode, with enhanced dynamic range, as a matrix scan) and luminescence. Every read is checked and encoded exactly as on the device (the same argument checks and the same RUN parameters), and nothing is sent.simulated_data(from the device or from simulation), so a protocol can be replayed with real data._get_run_parameters), which the simulator calls; the device's reads send the same bytes as before.NotImplementedErrorin simulation for now.🤖 Generated with Claude Code