Repository navigation
Conversation
- `setUpModule` starts and closes one browser with 120 s to come up: a fresh runner's first Chrome launch loads Chrome, its fonts and its renderer from cold, sometimes past the 30 s the module's first test had, which failed it with "could not attach to a headless browser". - `Browser` takes its attach deadline as an argument; every test keeps its 30 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
BrowserTests.test_a_click_on_a_row_selects_unless_it_is_on_the_arrowfails on CI again and again with "could not attach to a headless browser": 7 of the last 8 failed test runs, on main and on branches. Nothing in it is wrong: it is the first test of the module, so it launches the job's first Chrome. On a fresh runner that launch also loads Chrome, its fonts and its software renderer from cold, which takes up to tens of seconds, and sometimes more than the 30 s a browser has to come up. Every later launch takes a few seconds.PR Content
setUpModulestarts and closes one browser before any test, with 120 s to come up, so the cold start is paid once and by no test.Browsertakes its attach deadline as an argument; every test keeps its 30 s, so a browser that does hang still fails as fast as before.With Chrome's first launch held back by 35 s, main fails that test as CI does and this branch passes all 23.
🤖 Generated with Claude Code