Make borrow-state tests portable on 32-bit targets - #566
Open
heiserhorn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #565.
The borrow-state tests assert exact values of the process-global borrow-flag count. On Debian i386, the no-feature test suite can observe an additional registered flag and fail even though the array-count and safety checks remain valid.
Gate the exact
n_flagsstate and assertions on 64-bit targets while retaining the other borrow-state checks on all architectures. This keeps the test meaningful without requiring a platform-dependent global registry count on 32-bit systems.Validation:
cargo test --lib borrow::shared::tests::borrow_multiple_arrayspassed.git diff --checkpassed.rust-numpy 0.28.0-4i386 sbuild passed with the equivalent packaging patch.