Skip to content

fix(scip): respect verbosity when reading problem files - #991

Open
Ketchp wants to merge 2 commits into
PyPSA:masterfrom
Ketchp:fix/scip-quiet-output
Open

Ketchp wants to merge 2 commits into
PyPSA:masterfrom
Ketchp:fix/scip-quiet-output

Conversation

@Ketchp

@Ketchp Ketchp commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Note

This commit message was generated by AI.

Apply solver options before reading the problem file so display/verblevel=0 suppresses the initial model-loading output. Add a regression test and an upcoming release note.

Changes proposed in this Pull Request

Moved call to readProblem so that solver options are applied first.

Previously model stdout output could not be completely silenced since readProblem prints to console by default.

Important note:
SCIP option reading/initialconss configures readProblem, so previously this option was ignored (had no effect).
After this change, the option will no longer be ignored.
For users who specified this option without realizing it is ignored, this can lead to different outputs.
By default this option is True, so users who specified reading/initialconss=False can start getting 1e99 sentinel for dual instead of real dual if solver stops early due to objective cutoff.
Also I am not sure whether it is intentional that SCIP_INVALID=1e99 are not parsed as NaN. I can fix this also if you want.

Checklist

  • AI-generated content is marked (see AGENTS.md).
  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

> [!NOTE]
> This commit message was generated by AI.

Apply solver options before reading the problem file so display/verblevel=0 suppresses the initial model-loading output. Add a regression test and an upcoming release note.
@codspeed

codspeed Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 181 untouched benchmarks
⏩ 181 skipped benchmarks1


Comparing Ketchp:fix/scip-quiet-output (46ccb1f) with master (1b2ea76)

Open in CodSpeed

Footnotes

  1. 181 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

> [!NOTE]
> This commit message was generated by AI.

Annotate the solver options dictionary to match the heterogeneous keyword arguments accepted by Model.solve.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant