Fix MOO slippage reference price - #9763
Open
matvt-cell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9753.
Daily
MarketOnOpenfills use the bar'sOpenas the execution price, butConstantSlippageModelpreviously calculated percentage slippage from the latest data value. For a dailyTradeBar, that value is the same-dayClose, introducing look-ahead bias into the MOO fill price.This change:
ISlippageModeloverload that accepts an explicit reference priceConstantSlippageModelto calculate percentage slippage from that reference priceEquityFillModel.MarketOnOpenFillto pass the selected pre-slippage execution priceISlippageModelimplementations through the default interface implementationTests
Added a regression test covering both buy and sell daily MOO orders and verifying that changing only the fill-day
Closedoes not change the fill price.Verification:
EquityFillModelTests: 126 passedSlippageModelsTests: 7 passedISlippageModelimplementations passes