Rebase: require a same-repo head branch (fork noise guard)#18
Merged
Conversation
Mirrors action-translation#130; see the PAT rollout review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR hardens the rebase-translations GitHub Actions workflow by preventing the job from running on merged pull requests whose head branch comes from a fork, avoiding a predictable “empty secret” failure mode.
Changes:
- Adds a same-repository head-branch guard to the rebase job’s
if:condition. - Documents why the guard is needed and why it does not change secret-exposure risk.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📖 Netlify Preview Ready!Preview URL: https://pr-18--verdant-toffee-3261a8.netlify.app Commit: Build Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line hardening from Copilot's review of the PAT rollout (.fr#17 comment, applied estate-wide): the rebase job now requires a same-repo head branch. Fork PRs never receive secrets — the PAT was not exposed — but a merged fork PR whose branch happened to match a translation prefix would start the job with an empty token and fail red; it is now skipped. Mirrors action-translation#130 and the harness copies.
🤖 Generated with Claude Code