feat: real designs for Keystone hardware wallet signup and signing - #591
Open
n13 wants to merge 3 commits into
Open
feat: real designs for Keystone hardware wallet signup and signing#591n13 wants to merge 3 commits into
n13 wants to merge 3 commits into
Conversation
- render icons - fix steps
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Replaces the dev-design Keystone screens with the real designs from the Quantus Redesign Figma.
Screenshots: See below (simulator)
Designs:
Add Keystone flow (2 screens)
AddHardwareAccountScreenrewritten as the intro screen: hero product image, headline, "Connect Hardware Wallet" button, and a "Don't have one? Get a Keystone ↗" link. Constructor unchanged, so existing callers (add-account menu, create-account) are untouched.ConnectKeystoneScreen: firmware reminder + on-device steps with the Figma icons, then "Ready to Scan" opens the QR scanner. The name/address form is gone — the account is created directly after scanning (name defaults to "Keystone Wallet"). Debug test-address path kept inkDebugMode.Send signing flow — now a 3-step journey
Most of the send flow is unchanged; the branch where the user signs with Keystone is redesigned:
KeystoneSignScreen: step indicator, "Scan with your Keystone", bordered QR card, "YOU ARE SIGNING" details (amount/recipient + checksum), "Continue to Sign" / "Cancel Transaction".KeystoneVerifyScreen: "Check your Keystone Screen" — dark summary card with amount and recipient, red mismatch warning, "Continue to Sign" / "It doesn't match".AnimatedQrScannerrestyled: app bar, step header, rounded camera view with corner brackets, "RECEIVING SIGNATURE" progress bar.KeystoneRejectScreen("It doesn't match"): reject-on-device instructions, "I rejected it on Keystone", "Contact Support" mailto.Multisig hardware signing gets the same new flow automatically since it shares these screens.
Supporting changes
textSubtlecolor inAppColorsV2, sharedKeystoneStepLabel/KeystoneWarningCardwidgets,UnderlinedTextLinkcomponentassets/v2/KeystoneSigningSession.title(app bar is "Sign with Keystone" per design)Deliberate deviations from Figma
Testing
melos run formatclean;dart analyze --fatal-infosclean onlib/andtest/(melos' own analyze run kept crashing its analysis server on mobile-app — env flake, not a code issue)AppConstants.debugHardwareWalletto force the Keystone path for testing without hardware