Make max fragment length configurable at encode time - #3
Open
n13 wants to merge 1 commit into
Open
Conversation
Add encode_bytes_with_options / encode_hex_with_options taking a max_fragment_length so clients can trade fragment count for QR density (fewer, denser frames scan faster phone-to-phone). The plain encode_* functions keep the 200-byte default. The decoder's per-fragment bound moves from 200 to 4096 bytes so it accepts denser frames; the 200 KiB total-message envelope and all other inbound validation are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets clients choose the bytes per QR fragment instead of the hardcoded 200, so animated QR transfers can use fewer, denser frames (phone-to-phone scanning handles much denser QRs than hardware-wallet cameras).
encode_bytes_with_options/encode_hex_with_options; existingencode_*keep the 200-byte default