Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: log armor stand equipment before it is dropped on break
Vanilla calls brokenByAnything, which drops all equipment and empties
every slot, before it calls kill. Logging at the kill call therefore
stored an armor stand whose equipment tag was omitted entirely, so a
rollback brought back an empty stand and the items were lost.
Log at the head of brokenByAnything instead, while the equipment is
still attached, and guard the existing kill hooks so the break is not
recorded twice. The kill hooks still cover the paths that skip
brokenByAnything (creative players, damage bypassing invulnerability).