fix: Add visual invalid input handling beyond color#10101
Open
lizschwab wants to merge 1 commit into
Open
Conversation
maribethb
reviewed
Jul 6, 2026
maribethb
left a comment
maribethb
left a comment
Contributor
There was a problem hiding this comment.
adding a new media url is a breaking change, as discussed offline, but reviewed the rest of it
| } | ||
|
|
||
| /** Creates the DOM elements for the invalid input warning icon. */ | ||
| private createWarningIcon(parent?: Element | null): HTMLImageElement | null { |
Contributor
There was a problem hiding this comment.
I'd go ahead and make this protected so that subclasses can modify it if desired
| if (!this.isTextValid_) { | ||
| dom.addClass(htmlInput, 'blocklyInvalidInput'); | ||
| aria.setState(htmlInput, aria.State.INVALID, true); | ||
| // insert the icon |
Contributor
There was a problem hiding this comment.
I'd probably move this logic to a function call to keep the render_ method smaller and make it easier for subclasses to also call that function in case they override render.
| } | ||
|
|
||
| /** Creates the DOM elements for the invalid input warning icon. */ | ||
| private createWarningIcon(parent?: Element | null): HTMLImageElement | null { |
Contributor
There was a problem hiding this comment.
Do you need to accept the parent as a parameter? you only call this in one place and you don't pass it in, you just append it manually to the dom after creation. I would remove this unless I'm overlooking something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9684
Proposed Changes
Added a warning icon which is displayed when a field's input is invalid. This is to address the Use of Color WCAG guidelines.
Zelos Renderer
Zoomed in:
Zoomed out:
RTL:
Geras Renderer
Zoomed in:
Zoomed out:
RTL:
Test Coverage
Tests added to ensure icon is added appropriately and aria-invalid state is set.