fix: export JSON block definition type#10102
Open
yuanran32 wants to merge 2 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10086
Proposed Changes
Exports
JsonBlockDefinitionfromblockly.tsso it is available through the publicblockly/coreentry point.Also updates the TypeScript test fixture to import
JsonBlockDefinitionfromblockly-test/coreinstead of the internalinterfaces/i_json_block_definitionpath.
Reason for Changes
JsonBlockDefinitionwas added in #9613, but it was not re-exported fromblockly.ts. As a result, users could not access the type from the expected publicBlockly core export.
This PR adds the missing re-export.
Test Coverage
Updated the TypeScript test fixture for JSON block custom args to verify that
JsonBlockDefinitioncan be imported fromblockly-test/core.Validated with
npm.cmd run tsc -w packages/blocklyDocumentation
No documentation changes needed.