Conversation
Use the validation debug message when an asset transaction is rejected without a reject reason. Add a regression test for both fallback and existing reject-reason paths.\n\nFixes RavenProject#1220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Asset transfers that are rejected during wallet commit can show a blank reason in Raven-Qt.
SendAssetTransaction()only usedCValidationState::GetRejectReason(), even when validation supplied diagnostic text throughGetDebugMessage(). This matches the blank-reason dialog reported in #1220.Approach
FormatStateMessage()when the reject reason is empty so the debug message and validation code reach the caller.Test plan
git diff --checkFixes #1220