Conversation
Increase the Qt wallet's recommended confirmation threshold from six to sixty blocks to match the safer interval requested in issue RavenProject#619. Keep the change in the presentation layer; consensus and wallet trust rules are unchanged. Add a Qt regression assertion for the published threshold.\n\nRefs RavenProject#619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Qt wallet labels ordinary transactions as confirmed after six confirmations. Issue #619 notes that this interval is short for Ravencoin and requests a safer default closer to one hour.
Change
Raise the Qt presentation-layer recommended threshold from 6 to 60 confirmations. The consensus rules and wallet trust/balance accounting are unchanged. Update the associated status comment and add a Qt regression assertion for the threshold.
Test plan
git diff --checkRisk and exclusions
This changes only when the Qt UI reports a normal transaction as having the recommended number of confirmations. It does not alter consensus, transaction validity, RPC defaults, or restricted-asset consensus behavior.
Refs #619