Conversation
Accumulate positive address-index received deltas in an unsigned type with overflow checks so large cumulative totals cannot wrap into negative RPC results. Cover the signed-boundary and uint64 overflow cases with a unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getaddressbalanceaccumulated the lifetimereceivedvalue in signedCAmount(int64_t). Addresses with more thanINT64_MAXreceived satoshis wrapped into a negative RPC result, as reported in #1227.Approach
Accumulate positive address-index deltas in checked
uint64_tstorage for both the RVN andincludeAssetspaths. Return an RPC error rather than wrapping if the unsigned range is exceeded. Keep the current numeric JSON representation.Test plan
rpc_received_amount_overflow_testcovers crossing the signed boundary, ignoring negative deltas forreceived, and rejecting unsigned overflow.received-overflow-helper: PASSfrom an UBSan-enabled helper smoke test.git diff --cached --checkpassed.Fixes #1227