Skip to content

Avoid -Wdeprecated-copy warnings #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enchufa2 merged 3 commits into from
Sep 3, 2026
+7 −18
Merged

Avoid -Wdeprecated-copy warnings #1503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45c9834
add -Wdeprecated-copy
Enchufa2 Sep 3, 2026
8391a38
remove redundant copy operators
Enchufa2 Sep 3, 2026
e86ecb9
update ChangeLog
Enchufa2 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/werror.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
_R_CHECK_FORCE_SUGGESTS_: "false"
RCPP_CXXFLAGS: "-Werror -Wcast-function-type"
RCPP_CXXFLAGS: "-Werror -Wcast-function-type -Wdeprecated-copy"

jobs:
ci:
Expand Down
6 changes: 6 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@
* inst/tinytest/testRcppInterfaceExporter/src/RcppExports.cpp: Idem
* inst/tinytest/testRcppInterfaceExporter/inst/include/testRcppInterfaceExporter_RcppExports.h: Idem

* .github/workflows/werror.yaml: Add -Wdeprecated-copy

* inst/include/Rcpp/date_datetime/newDateVector.h: Remove redundant custom
copy operator to avoid -Wdeprecated-copy warnings
* inst/include/Rcpp/date_datetime/newDatetimeVector.h: Idem

2026-09-01 Iñaki Ucar <iucar@fedoraproject.org>

* .github/workflows/werror.yaml: Add new CI file with -Werror enabled
Expand Down
8 changes: 0 additions & 8 deletions inst/include/Rcpp/date_datetime/newDateVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@ namespace Rcpp {
return v;
}

inline newDateVector &operator=(const newDateVector &rhs) {
if (this != &rhs) {
NumericVector::operator=(rhs);
}

return *this;
}

friend inline std::ostream &operator<<(std::ostream & s, const newDateVector d);

private:
Expand Down
9 changes: 0 additions & 9 deletions inst/include/Rcpp/date_datetime/newDatetimeVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,6 @@ namespace Rcpp {
return v;
}

inline newDatetimeVector &operator=(const newDatetimeVector &rhs) {
if (this != &rhs) {
NumericVector::operator=(rhs);
this->attr("tzone") = rhs.attr("tzone");
}

return *this;
}

friend inline std::ostream &operator<<(std::ostream & s, const newDatetimeVector d);

private:
Expand Down
Loading