Repository navigation
S4 module metadata (2 of 2, over #1515) - #1516
Conversation
Enchufa2
left a comment
Enchufa2
left a comment
There was a problem hiding this comment.
A rebase is needed, and an updated ChangeLog.
| .cpp_methods_info <- function( x, prefix = " " ){ | ||
| paste( | ||
| paste( prefix, x@signatures, ifelse(x@const, " const", "" ), "\n", prefix, prefix, | ||
| ifelse( nchar(x@docstrings), paste( "docstring :", x@docstrings) , "" ) | ||
| ) , collapse = "\n" ) | ||
| } |
There was a problem hiding this comment.
Do we really need this? This is called once per method, so after the savings of this PR, this probably takes a lot of time. S4_CppOverloadedMethods in the C++ side already loops over every overload, so we could build each signature and store it in a docinfo slot.
|
Good point in the missing rebase. What I tested was a '1515 and 1516' combination but then I only merged 1515 so far. |
|
BTW, and of course, the only shortcoming of this PR is that a package built against this won't load with an older version of Rcpp (but it does work the other way around). I think we can live with this. |
ed59ef4 to
b391bab
Compare
|
Rebased and updated the ChangeLog. If you already tested this with the revdeps checks, then I propose to merge it and we could address what I raised above as a separate PR. |
|
Good plan, squash-merging as usual. |
|
Thanks!! |
|
Thanks to you for taking the time to put this together! |
3 participants
plain S4 objects for module metadata, applies over #1515
https://github.com/mdsumner/Rcpp/blob/code-docs-speedup-namespace-load/rcppmoduleloadtime.md