Skip to content

Reset isReal test per-column to fix forder() with na.last=TRUE - #7877

Open
MichaelChirico wants to merge 3 commits into
masterfrom
forder-na-last
Open

Reset isReal test per-column to fix forder() with na.last=TRUE#7877
MichaelChirico wants to merge 3 commits into
masterfrom
forder-na-last

Conversation

@MichaelChirico

Copy link
Copy Markdown
Member

Closes #7875

isReal must be reset on each column lest the state leak with the consequences we observe in the bug. The bug only affects combinations of real-then-non-real, but we include regression tests for real-real pairs as well (which includes real-complex).

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
  • HEAD=forder-na-last much slower for as.data.table.array improved in #7019
    Comparison Plot

Generated via commit 87ce751

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 52 seconds
Installing different package versions 0 seconds
Running and plotting the test cases 5 minutes and 45 seconds

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (561a869) to head (87ce751).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7877   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17292    17292           
=======================================
  Hits        17122    17122           
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

forder incorrect for na.last=TRUE and double column, descending character column

1 participant