Skip to content

isoweek()/isoyear(): compute in C via convertDate() - #7951

Merged
ben-schwen merged 1 commit into
masterfrom
isoweek-c
Nov 1, 2026
Merged

ben-schwen merged 1 commit into
masterfrom
isoweek-c

Conversation

@m-muecke

Copy link
Copy Markdown
Contributor

another 1.35-2x speed up

@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (7b7f63b) to head (1007eac).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7951   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          88       88           
  Lines       17420    17429    +9     
=======================================
+ Hits        17261    17270    +9     
  Misses        159      159           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
  • HEAD=isoweek-c much faster for Date-IDate regression in #7213
  • HEAD=isoweek-c much faster for DT[by,verbose=TRUE] improved in #6296
  • HEAD=isoweek-c much slower for fwrite refactored in #6393
  • HEAD=isoweek-c faster P<0.001 for memrecycle regression fixed in #5463

(Plot image upload to picrd.com failed; download the artifact below to view plots)

Generated via commit 1007eac

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 1 minutes and 50 seconds
Installing different package versions 8 minutes and 30 seconds
Running and plotting the test cases 3 minutes and 58 seconds

@ben-schwen

Copy link
Copy Markdown
Member

LGTM TY!

@ben-schwen
ben-schwen merged commit fe94435 into master Nov 1, 2026
15 checks passed
@ben-schwen
ben-schwen deleted the isoweek-c branch November 1, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants