Skip to content

[SVS] Refactor SVS element size calculations and block size handling#980

Open
rfsaliev wants to merge 4 commits into
mainfrom
rfsaliev/svs-blocksize-elements
Open

[SVS] Refactor SVS element size calculations and block size handling#980
rfsaliev wants to merge 4 commits into
mainfrom
rfsaliev/svs-blocksize-elements

Conversation

@rfsaliev

@rfsaliev rfsaliev commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Describe the changes in the pull request

This pull request refactors and improves the way element sizes and block sizes are calculated and used in the SVS storage traits, enhancing clarity and modularity in the code. The changes introduce clearer separation between primary, residual, and secondary element sizes, update the block size calculation to use a new structure, and simplify related test logic.

Which issues this PR fixes

This PR fixes index size estimation issues for SVSIndex by using new blocksize_elements parameter introduced in intel/ScalableVectorSearch#344.

TODO:

  • Update SVS shared library binary URLs

Main objects this PR modified

  1. SVSIndex
  2. SVS tests

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Medium Risk
Changes affect SVS memory layout, blocking, and size estimation for quantized indexes; risk is mitigated by test updates and a dependency bump rather than API changes.

Overview
SVS index size estimation and blocked storage are updated to match Intel ScalableVectorSearch v0.3.2 (shared library URLs in cmake/svs.cmake bumped from v0.3.1 to v0.3.2).

SVSBlockSize now returns svs::data::BlockingParameters with both byte block size and element-count block size (blocksize_elements from upstream #344), instead of a single PowerOfTwo.

For LVQ and LeanVec traits, element sizing is split into primary, residual, and secondary helpers; blocked allocators use the max of the relevant component sizes when computing blocks. Total element_size is the sum of those parts.

Tests: testSizeEstimation drops the old LVQ dimension fudge and uses 1% tolerance for per-block growth estimates; tiered runGCAPI sets blockSize to threshold/2 so deletes span at least two blocks (workaround for SVS keeping one empty block on shrink).

Reviewed by Cursor Bugbot for commit 7e7d646. Bugbot is set up for automated code reviews on this repo. Configure here.

@rfsaliev rfsaliev requested a review from meiravgri June 17, 2026 09:55
@jit-ci

jit-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

Comment thread cmake/svs.cmake
@rfsaliev rfsaliev marked this pull request as ready for review June 18, 2026 11:55
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (dd6879e) to head (7e7d646).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   97.12%   97.13%           
=======================================
  Files         141      141           
  Lines        8245     8260   +15     
=======================================
+ Hits         8008     8023   +15     
  Misses        237      237           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfsaliev rfsaliev requested review from alonre24 and removed request for meiravgri June 25, 2026 16:00
alonre24
alonre24 previously approved these changes Jul 1, 2026

@alonre24 alonre24 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did we confirm that there is no regression in terms of memory consumption in benchmarks?

Comment thread cmake/svs.cmake Outdated
if(GLIBC_VERSION VERSION_GREATER_EQUAL "2.28")
if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "14.0")
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.3.0/svs-shared-library-0.3.0-reduced-gcc14.tar.gz" CACHE STRING "SVS URL")
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/nightly/svs-shared-library-reduced-gcc14-2026-06-18-1414.tar.gz" CACHE STRING "SVS URL")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to merge it as it is (using the nightly version) or bump to an official svs release?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alonre24, now there is SVS v.0.3.2 release used in this change.
FYI: SVS v.0.3.2 = v.0.3.1 + LVQ exports required to compute 'Residual' element size.

@rfsaliev rfsaliev force-pushed the rfsaliev/svs-blocksize-elements branch from 465995d to fcc801d Compare July 10, 2026 09:12
@rfsaliev rfsaliev force-pushed the rfsaliev/svs-blocksize-elements branch from fcc801d to 48ce76c Compare July 14, 2026 15:59
@rfsaliev rfsaliev requested review from alonre24 and ethanglaser July 16, 2026 08:36
@rfsaliev rfsaliev enabled auto-merge July 16, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants