[SVS] Add TopKSearchDuringUpdate SVS benchmark#993
Open
rfsaliev wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage 97.10% 97.10%
=======================================
Files 141 141
Lines 8179 8179
=======================================
Hits 7942 7942
Misses 237 237 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add benchmark for TopK searches during SVS backend index update
Which issues this PR fixes
Main objects this PR modified
Mark if applicable
Note
Low Risk
Benchmark-only changes with no API, serialization, or production VecSim logic modifications.
Overview
Adds a new
BM_TopKSearchDuringUpdateSVS benchmark to measure real time while parallel TopK queries run alongside a tiered index background update (flat buffer → SVS backend).The harness pre-fills the flat buffer to one vector below
update_threshold, then on each iteration triggers the update with oneAddVector, launchesn_parallel_searchesthreads each callingVecSimIndex_TopKQuery(fixed k=100, window_size=200), joins them, and waits for the mock thread pool to finish the update. Benchmark args sweep update_threshold (block size / 5k / 10× block), 10 vs 50 concurrent searches, and 2 vs 4 index thread-pool threads; registration is wired in the fp32 SVS basics init header like the existing tiered benchmarks.Reviewed by Cursor Bugbot for commit 3110ad0. Bugbot is set up for automated code reviews on this repo. Configure here.